You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "FangYongs (via GitHub)" <gi...@apache.org> on 2023/10/12 02:03:44 UTC
[PR] [FLINK-33033][test] Add curator-test for flink-benchmarks [flink]
FangYongs opened a new pull request, #23513:
URL: https://github.com/apache/flink/pull/23513
## What is the purpose of the change
This PR aims to add curator-test dependency in flink-test-utils project which will used in flink-benchmarks. Then we can use zookeeper testing server in flink-benchmarks and the version of curator-test can be consistent with flink version.
## Brief change log
- Add curator-test in flink-test-utils
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no) no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no) no
- The serializers: (yes / no / don't know) no
- The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) no
- The S3 file system connector: (yes / no / don't know) no
## Documentation
- Does this pull request introduce a new feature? (yes / no) no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33033][test] Add curator-test for flink-benchmarks [flink]
Posted by "FangYongs (via GitHub)" <gi...@apache.org>.
FangYongs merged PR #23513:
URL: https://github.com/apache/flink/pull/23513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33033][test] Add curator-test for flink-benchmarks [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23513:
URL: https://github.com/apache/flink/pull/23513#issuecomment-1758801437
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7846f0e6cc9d9b4d4087d7239dadc7944601fb3a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7846f0e6cc9d9b4d4087d7239dadc7944601fb3a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7846f0e6cc9d9b4d4087d7239dadc7944601fb3a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33033][test] Add curator-test for flink-benchmarks [flink]
Posted by "KarmaGYZ (via GitHub)" <gi...@apache.org>.
KarmaGYZ commented on code in PR #23513:
URL: https://github.com/apache/flink/pull/23513#discussion_r1355969956
##########
flink-test-utils-parent/flink-test-utils/pom.xml:
##########
@@ -163,6 +163,17 @@ under the License.
<scope>runtime</scope>
</dependency>
+ <!-- This dependency is added for `flink-benchmarks` project which will
+ use zookeeper testing server to benchmark olap performance. This dependency
+ is added here to ensure that its version is consistent with the flink
+ version in the `flink-benchmarks` and to avoid conflicts. Removing this
+ dependency may cause failure of `flink-benchmarks`. -->
+ <dependency>
+ <groupId>org.apache.curator</groupId>
+ <artifactId>curator-test</artifactId>
+ <version>${curator.version}</version>
+ </dependency>
+
Review Comment:
As discussed in https://github.com/apache/flink-benchmarks/pull/78,
> We might want to add a comment to the corresponding line in [apache/flink:pom.xml:144](https://github.com/apache/flink/blob/ec6ebe2d22d15883f7236895387a45a533cfefe0/pom.xml#L144) to point out that updating the curator version in Flink should result in updating the corresponding version in Flink's benchmark tests as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33033][test] Add curator-test for flink-benchmarks [flink]
Posted by "FangYongs (via GitHub)" <gi...@apache.org>.
FangYongs commented on PR #23513:
URL: https://github.com/apache/flink/pull/23513#issuecomment-1758799247
@KarmaGYZ Please help to review this PR when you're free, it is related to https://github.com/apache/flink-benchmarks/pull/78
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33033][test] Add curator-test for flink-benchmarks [flink]
Posted by "FangYongs (via GitHub)" <gi...@apache.org>.
FangYongs commented on code in PR #23513:
URL: https://github.com/apache/flink/pull/23513#discussion_r1356001155
##########
flink-test-utils-parent/flink-test-utils/pom.xml:
##########
@@ -163,6 +163,17 @@ under the License.
<scope>runtime</scope>
</dependency>
+ <!-- This dependency is added for `flink-benchmarks` project which will
+ use zookeeper testing server to benchmark olap performance. This dependency
+ is added here to ensure that its version is consistent with the flink
+ version in the `flink-benchmarks` and to avoid conflicts. Removing this
+ dependency may cause failure of `flink-benchmarks`. -->
+ <dependency>
+ <groupId>org.apache.curator</groupId>
+ <artifactId>curator-test</artifactId>
+ <version>${curator.version}</version>
+ </dependency>
+
Review Comment:
We don't need to add corator-test dependency in flink-benchmark after adding it here, so we may not need to add comment in [apache/flink:pom.xml:144](https://github.com/apache/flink/blob/ec6ebe2d22d15883f7236895387a45a533cfefe0/pom.xml#L144). WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org