[GitHub] [airflow] dstandish commented on a diff in pull request #25920: Rename DatasetDagRef to DatasetConsumerDag

[GitBox <gi...@apache.org>]

dstandish commented on code in PR #25920:
URL: https://github.com/apache/airflow/pull/25920#discussion_r954275961


##########
airflow/api_connexion/openapi/v1.yaml:
##########
@@ -3553,7 +3553,7 @@ components:
           description: The dataset update time
           nullable: false
 
-    DatasetDagRef:
+    DagDatasetConsumer:

Review Comment:
   i'll just mention though... the reason i thought it makes sense to put Dag first, is cus it's the reference from dag to dataset.  
   
   so if we didn't have to specify type of reference (i.e. consumer vs producer) then it would be a pretty easy choice i think.... we'd just call it `dag_dataset` since it's just a mapping from dag to dataset.
   
   and so i figured, just add a suffix indicating type: dag_dataset_consumer
   
   but, i guess another way to think about it is, not so much as a mapping table, but more as an entity unto itself, e.g. a DatasetConsumer entity of type Dag....  which... i guess is how y'all are thinking about it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org