You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/01/24 00:41:01 UTC

[GitHub] [netbeans] DevCharly commented on a change in pull request #2701: [NETBEANS-5272] Fixed grouping of documents in document switcher

DevCharly commented on a change in pull request #2701:
URL: https://github.com/apache/netbeans/pull/2701#discussion_r563217819



##########
File path: platform/core.multitabs/src/org/netbeans/core/multitabs/impl/DocumentSwitcherTable.java
##########
@@ -225,21 +225,27 @@ public TabData getTabData() {
         }
 
         @Override
-        public int compareTo( Object o ) {
-            if( o instanceof Item ) {
-                ProjectProxy otherProject = ((Item)o).project;
-                if( null == project && null != otherProject )
+        public int compareTo(Object o) {

Review comment:
       I think you should avoid all whitespace changes.
   They make the review (here on GitHub) harder because it is difficult to find the real changes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists