[GitHub] [camel-website] favourori commented on issue #189: opening foreign links in new tab

[GitBox <gi...@apache.org>]

favourori commented on issue #189: opening foreign links in new tab
URL: https://github.com/apache/camel-website/pull/189#issuecomment-597510125
 
 
   No problem. 
   
   Let me work on that.
   
   Best,
   Favour 
   
   > On Mar 11, 2020, at 10:27 AM, Zoran Regvart <no...@github.com> wrote:
   > 
   > 
   > @zregvart requested changes on this pull request.
   > 
   > I don't think this solves the problem as a whole, we need add the rel attribute for all external links.
   > 
   > In config.toml:
   > 
   > > @@ -83,7 +83,7 @@ timeout = 300000
   >      parent = "docs"
   >      weight = 4
   >      identifier = "api-documentation"
   > -    url = "https://www.javadoc.io/doc/org.apache.camel/camel-api/latest/index.html" 
   > +    url = "https://www.javadoc.io/doc/org.apache.camel/camel-api/latest" 
   > Not sure this needs to be changed, can you elaborate?
   > 
   > In layouts/partials/header.html:
   > 
   > > @@ -42,12 +42,16 @@
   >                              <a class="navbar-link" href="#">{{ .Name }}</a>
   >                              <div class="navbar-dropdown">
   >                                  {{ range .Children }}
   > +                                {{ if strings.HasPrefix .URL "https" }}
   > +                                <a class="navbar-item" href="{{ .URL | relURL }}" target="_blank" rel="noopener">{{ .Name }}</a>
   > This adds target and rel attributes for one link on the menu. What we need is something that will add this for all external links regardless of where they are rendered from.
   > 
   > The issue in question has some pointers on how to accomplish that.
   > 
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub, or unsubscribe.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services