You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/06 21:17:51 UTC
[GitHub] [beam] Abacn opened a new pull request, #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Abacn opened a new pull request, #17305:
URL: https://github.com/apache/beam/pull/17305
* Added overload versions of continuously for FileIO.match and .matchAll
accepting a third matchUpdatedFiles parameter.
* Watching for both new files and timestamp change of existing files
when matchUpdatedFiles is set as true
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1154648829
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1152607041
Run Java PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
aaltay commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1112497651
@johnjcasey - could you ping a committer to get this merged after tests pass?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1113883546
Run PostCommit_Java_Dataflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1152605833
phrase "retest this please" no longer working... trying another dumb push to trigger
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1154649869
Run Java PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1090817475
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on a diff in pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
Abacn commented on code in PR #17305:
URL: https://github.com/apache/beam/pull/17305#discussion_r849875918
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/storage/GcsMatchIT.java:
##########
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.gcp.storage;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+
+import com.google.common.io.ByteStreams;
+import java.io.ByteArrayInputStream;
+import java.io.IOException;
+import java.nio.channels.Channels;
+import java.nio.channels.ReadableByteChannel;
+import java.nio.channels.WritableByteChannel;
+import java.util.Arrays;
+import java.util.Date;
+import java.util.List;
+import org.apache.beam.sdk.Pipeline;
+import org.apache.beam.sdk.PipelineResult;
+import org.apache.beam.sdk.PipelineResult.State;
+import org.apache.beam.sdk.extensions.gcp.options.GcsOptions;
+import org.apache.beam.sdk.extensions.gcp.util.gcsfs.GcsPath;
+import org.apache.beam.sdk.io.FileIO;
+import org.apache.beam.sdk.io.FileSystems;
+import org.apache.beam.sdk.io.fs.MatchResult.Metadata;
+import org.apache.beam.sdk.io.fs.ResourceId;
+import org.apache.beam.sdk.testing.PAssert;
+import org.apache.beam.sdk.testing.TestPipeline;
+import org.apache.beam.sdk.testing.TestPipelineOptions;
+import org.apache.beam.sdk.transforms.Create;
+import org.apache.beam.sdk.transforms.MapElements;
+import org.apache.beam.sdk.transforms.Watch;
+import org.apache.beam.sdk.util.MimeTypes;
+import org.apache.beam.sdk.values.PCollection;
+import org.apache.beam.sdk.values.TypeDescriptors;
+import org.joda.time.Duration;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
+
+@RunWith(JUnit4.class)
+public class GcsMatchIT {
+ /** Integration test for TextIO.MatchAll watching for file updates in gcs filesystem */
+ @Test
+ public void testGcsMatchContinuously() throws InterruptedException {
+ TestPipelineOptions options =
+ TestPipeline.testingPipelineOptions().as(TestPipelineOptions.class);
+ assertNotNull(options.getTempRoot());
+ options.setTempLocation(options.getTempRoot() + "/testGcsMatchContinuouslyTest");
+ GcsOptions gcsOptions = options.as(GcsOptions.class);
+ String dstFolderName =
+ gcsOptions.getGcpTempLocation()
+ + String.format(
+ "/GcsMatchIT-%tF-%<tH-%<tM-%<tS-%<tL.testGcsMatchContinuously.copy/", new Date());
+ final GcsPath watchPath = GcsPath.fromUri(dstFolderName);
+
+ Pipeline p = Pipeline.create(options);
+
+ PCollection<Metadata> matchAllUpdatedMetadata =
+ p.apply("create for matchAll updated files", Create.of(watchPath.resolve("*").toString()))
+ .apply(
+ "matchAll updated",
+ FileIO.matchAll()
+ .continuously(
+ Duration.millis(250),
+ Watch.Growth.afterTimeSinceNewOutput(Duration.standardSeconds(3)),
+ true));
+
+ // Copy the files to the "watch" directory;
+ Thread writer =
+ new Thread(
+ () -> {
+ try {
+ Thread.sleep(1000);
Review Comment:
This test basically duplicates `org.apache.beam.sdk.io.testMatchWatchForNewFiles` and I am aware of that adding sleep makes the test time consuming. Also curious to see if there is a good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1096992674
Run Java Postcommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1096820043
Run PostCommit_Java_Dataflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1112588974
Run PostCommit_Java_Dataflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1152604873
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
aaltay commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1112497195
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
aaltay commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1112497308
Run Java_PVR_Flink_Docker PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on a diff in pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
johnjcasey commented on code in PR #17305:
URL: https://github.com/apache/beam/pull/17305#discussion_r849856522
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileIO.java:
##########
@@ -647,6 +699,14 @@ public void populateDisplayData(DisplayData.Builder builder) {
builder.include("configuration", getConfiguration());
}
+ /** Helper function creating a watch transform based on outputKeyFn. */
+ private <KeyT> Watch.Growth<String, MatchResult.Metadata, KeyT> CreateWatchTransform(
Review Comment:
This is a function, so the name should start lowercase to match java convention
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileIO.java:
##########
@@ -683,6 +743,18 @@ public String apply(MatchResult.Metadata input) {
return input.resourceId().toString();
}
}
+
+ private static class ExtractFilenameAndLastUpdateFn
+ implements SerializableFunction<MatchResult.Metadata, KV<String, Long>> {
+ @Override
+ public KV<String, Long> apply(MatchResult.Metadata input) throws RuntimeException {
+ long timestamp = input.lastModifiedMillis();
+ if (0L == timestamp) {
+ throw new RuntimeException("Extract file timestamp failed.");
Review Comment:
Lets be more descriptive here. Most likely, this will come up when a user does something unusual, and clear error messages are super helpful.
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/storage/GcsMatchIT.java:
##########
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.gcp.storage;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+
+import com.google.common.io.ByteStreams;
+import java.io.ByteArrayInputStream;
+import java.io.IOException;
+import java.nio.channels.Channels;
+import java.nio.channels.ReadableByteChannel;
+import java.nio.channels.WritableByteChannel;
+import java.util.Arrays;
+import java.util.Date;
+import java.util.List;
+import org.apache.beam.sdk.Pipeline;
+import org.apache.beam.sdk.PipelineResult;
+import org.apache.beam.sdk.PipelineResult.State;
+import org.apache.beam.sdk.extensions.gcp.options.GcsOptions;
+import org.apache.beam.sdk.extensions.gcp.util.gcsfs.GcsPath;
+import org.apache.beam.sdk.io.FileIO;
+import org.apache.beam.sdk.io.FileSystems;
+import org.apache.beam.sdk.io.fs.MatchResult.Metadata;
+import org.apache.beam.sdk.io.fs.ResourceId;
+import org.apache.beam.sdk.testing.PAssert;
+import org.apache.beam.sdk.testing.TestPipeline;
+import org.apache.beam.sdk.testing.TestPipelineOptions;
+import org.apache.beam.sdk.transforms.Create;
+import org.apache.beam.sdk.transforms.MapElements;
+import org.apache.beam.sdk.transforms.Watch;
+import org.apache.beam.sdk.util.MimeTypes;
+import org.apache.beam.sdk.values.PCollection;
+import org.apache.beam.sdk.values.TypeDescriptors;
+import org.joda.time.Duration;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
+
+@RunWith(JUnit4.class)
+public class GcsMatchIT {
+ /** Integration test for TextIO.MatchAll watching for file updates in gcs filesystem */
+ @Test
+ public void testGcsMatchContinuously() throws InterruptedException {
+ TestPipelineOptions options =
+ TestPipeline.testingPipelineOptions().as(TestPipelineOptions.class);
+ assertNotNull(options.getTempRoot());
+ options.setTempLocation(options.getTempRoot() + "/testGcsMatchContinuouslyTest");
+ GcsOptions gcsOptions = options.as(GcsOptions.class);
+ String dstFolderName =
+ gcsOptions.getGcpTempLocation()
+ + String.format(
+ "/GcsMatchIT-%tF-%<tH-%<tM-%<tS-%<tL.testGcsMatchContinuously.copy/", new Date());
+ final GcsPath watchPath = GcsPath.fromUri(dstFolderName);
+
+ Pipeline p = Pipeline.create(options);
+
+ PCollection<Metadata> matchAllUpdatedMetadata =
+ p.apply("create for matchAll updated files", Create.of(watchPath.resolve("*").toString()))
+ .apply(
+ "matchAll updated",
+ FileIO.matchAll()
+ .continuously(
+ Duration.millis(250),
+ Watch.Growth.afterTimeSinceNewOutput(Duration.standardSeconds(3)),
+ true));
+
+ // Copy the files to the "watch" directory;
+ Thread writer =
+ new Thread(
+ () -> {
+ try {
+ Thread.sleep(1000);
Review Comment:
It makes sense that we would need to sleep in a test to validate this functionality, but sleeping in tests is not usually a good practice. @chamikaramj or @pabloem is there a better pattern to use here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on a diff in pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
johnjcasey commented on code in PR #17305:
URL: https://github.com/apache/beam/pull/17305#discussion_r845239477
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileIO.java:
##########
@@ -627,16 +677,32 @@ public MatchAll continuously(
"Match filepatterns",
ParDo.of(new MatchFn(getConfiguration().getEmptyMatchTreatment())));
} else {
- res =
- input
- .apply(
- "Continuously match filepatterns",
- Watch.growthOf(
- Contextful.of(new MatchPollFn(), Requirements.empty()),
- new ExtractFilenameFn())
- .withPollInterval(getConfiguration().getWatchInterval())
- .withTerminationPerInput(getConfiguration().getWatchTerminationCondition()))
- .apply(Values.create());
+ if (getConfiguration().getMatchUpdatedFiles()) {
+ res =
Review Comment:
Because most of this code is duplicated, we should try and inspect .getMatchUpdatedFiles further in, or we should extract the duplicated code into a helper method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1090827478
R: @johnjcasey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj merged pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
chamikaramj merged PR #17305:
URL: https://github.com/apache/beam/pull/17305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
johnjcasey commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1152606643
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1090817477
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1090817476
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1091758131
Unit test `FileIOTest.testMatchWatchForNewFiles` is not stable. Trying to fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1098451425
R: @chamikaramj
R: @pabloem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1114046803
Run Java PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
aaltay commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1154681144
> Run Java PostCommit
Post commits phrases might still be disabled. (Please see the jenkins related dev thread.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1097026274
Comments addressed. The newly added integration test [passed](https://ci-beam.apache.org/job/beam_PostCommit_Java_PR/1016/testReport/org.apache.beam.sdk.io.gcp.storage/GcsMatchIT/). Ready for review now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1124488694
If finished review, this PR should be merged until #17604 (python counterpart of this feature) is also ready to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1113883617
Run PostCommit_Java_DataflowV2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files
Posted by GitBox <gi...@apache.org>.
johnjcasey commented on PR #17305:
URL: https://github.com/apache/beam/pull/17305#issuecomment-1112528259
Will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org