You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/08/05 14:05:33 UTC
[GitHub] [apisix-dashboard] FangSen9000 opened a new pull request, #2569: chore: move yarn to pnpm
FangSen9000 opened a new pull request, #2569:
URL: https://github.com/apache/apisix-dashboard/pull/2569
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Please update this section with detailed description.
**Related issues**
fix/resolve #0001
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [x] Have you added corresponding test cases?
- [x] Have you modified the corresponding document?
- [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] SkyeYoung commented on pull request #2569: chore: pnpm will be an optional manager
Posted by GitBox <gi...@apache.org>.
SkyeYoung commented on PR #2569:
URL: https://github.com/apache/apisix-dashboard/pull/2569#issuecomment-1210059539
It doesn't look like it's possible to use pnpm and yarn at the same time 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] FangSen9000 commented on pull request #2569: chore: pnpm will be an optional manager
Posted by GitBox <gi...@apache.org>.
FangSen9000 commented on PR #2569:
URL: https://github.com/apache/apisix-dashboard/pull/2569#issuecomment-1210064777
> It doesn't look like it's possible to use pnpm and yarn at the same time 🤔
When users or developers download it, they can use pnpm to download the dependent package. Pnpm uses package JSON. The command uses pnpm (although it essentially uses the package manager of the stored script)
Without the two dependency packages I added, pnpm users will spend a lot of time processing these packages. Those who download apifix dashboard using pnpm for the first time will spend a lot of time on them and will face three issues of pnpm:
1. Npmirc file setting problem
2. Peer dependency will not be automatically installed
3. Finally, there is still a lack of dependent packages
These documents will help them very well. However, the local developers or users of pnpm finally enjoy the fast download speed of dependent packages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] SkyeYoung commented on pull request #2569: chore: pnpm will be an optional manager
Posted by GitBox <gi...@apache.org>.
SkyeYoung commented on PR #2569:
URL: https://github.com/apache/apisix-dashboard/pull/2569#issuecomment-1210074023
@FangSen9000 But you don't keep the file pnpm-lock.yaml, which leads to two problems for developers who want to use it.
1. there are multiple versions of the dependencies used, which can lead to inconsistent versions being used by developers, making the entire software environment unstable.
2. The need to exclude pnpm-lock.yaml for each commit makes it more difficult for developers who are just starting out to contribute.
The above problems make it difficult to use "pnpm as an optional package manager", which leads to no one using pnpm as a package manager, and ultimately makes the whole PR ineffective.
On reflection, it is also very difficult to maintain dependencies for both package managers, so I suggest you try replacing yarn with pnpm instead of trying to make them co-exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] FangSen9000 commented on pull request #2569: chore: pnpm will be an optional manager
Posted by GitBox <gi...@apache.org>.
FangSen9000 commented on PR #2569:
URL: https://github.com/apache/apisix-dashboard/pull/2569#issuecomment-1210081517
> @FangSen9000但是您不保留文件pnpm-lock.yaml，这给想要使用它的开发人员带来了两个问题。
Ans1: I pointed out in the document that the required person can generate a pnpm lock through pnpm import: https://pnpm.io/cli/import
Ans2: it's OK to hand it in, because both yen.lock and pnpm lock will follow the package JSON update. And there will be no conflict between the two in the project. I tried. If not, I don't think it would be strange.
If it is completely replaced, we may have to give up the node JS 12. X support
When I restart the old branch and repeat the error, I will ask BZP for his opinion. However, the 15 or so format detection errors on the road are also a big project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] FangSen9000 closed pull request #2569: chore: pnpm will be an optional manager（WIP）
Posted by GitBox <gi...@apache.org>.
FangSen9000 closed pull request #2569: chore: pnpm will be an optional manager（WIP）
URL: https://github.com/apache/apisix-dashboard/pull/2569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] FangSen9000 commented on pull request #2569: chore: pnpm will be an optional manager
Posted by GitBox <gi...@apache.org>.
FangSen9000 commented on PR #2569:
URL: https://github.com/apache/apisix-dashboard/pull/2569#issuecomment-1210058210
> 文档和 package.json 文件已更改。锁定已上传最新的一个。您可以通过屏幕截图查看更改。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] FangSen9000 commented on pull request #2569: chore: pnpm will be an optional manager
Posted by GitBox <gi...@apache.org>.
FangSen9000 commented on PR #2569:
URL: https://github.com/apache/apisix-dashboard/pull/2569#issuecomment-1212631694
WIP, do not merge yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] FangSen9000 commented on pull request #2569: chore: pnpm will be an optional manager
Posted by GitBox <gi...@apache.org>.
FangSen9000 commented on PR #2569:
URL: https://github.com/apache/apisix-dashboard/pull/2569#issuecomment-1210057383
My work is carried out on the basis of predecessors. He failed, but I benefited a lot from his work. Then I also carried out more in-depth work.
@bzp2010 ‘s work：
https://github.com/apache/apisix-dashboard/pull/2459/files#
my work：
https://github.com/apache/apisix-dashboard/pull/2555/files
This work consists of two parts, GitHub workflow adjustment and project itself adjustment. The latter is easier, but the former is more difficult. Because our workflow needs to change too much.
After I spent 14 days in-depth, I found that there were too many GitHub workflows to be changed, and many of them could not be replaced and run temporarily. The workload was amazing. So I took this helpless solution: instead of completely replacing the package manager, I used pnpm as a supplementary solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] SkyeYoung commented on pull request #2569: chore: pnpm will be an optional manager
Posted by GitBox <gi...@apache.org>.
SkyeYoung commented on PR #2569:
URL: https://github.com/apache/apisix-dashboard/pull/2569#issuecomment-1210126381
> Ans1: I pointed out in the document that the required person can generate a pnpm lock through pnpm import: [pnpm.io/cli/import](https://pnpm.io/cli/import)
> Ans2: it's OK to hand it in, because both yen.lock and pnpm lock will follow the package JSON update. And there will be no conflict between the two in the project. I tried. I just think it would be strange for two locks to appear at the same time, but they do not interfere with each other.
This is exactly what I mentioned: it can cause problems with inconsistent dependency versions. The problem is not encountered now only because we are under a stable version and subsequent maintenance would be very difficult.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] FangSen9000 closed pull request #2569: chore: pnpm will be an optional manager
Posted by GitBox <gi...@apache.org>.
FangSen9000 closed pull request #2569: chore: pnpm will be an optional manager
URL: https://github.com/apache/apisix-dashboard/pull/2569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2569: chore: move yarn to pnpm
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2569:
URL: https://github.com/apache/apisix-dashboard/pull/2569#issuecomment-1207145091
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2569?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2569](https://codecov.io/gh/apache/apisix-dashboard/pull/2569?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49f469e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/adcd2e376635cad43c3518ac3ebabde4b6c2b854?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (adcd2e3) will **decrease** coverage by `9.90%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2569 +/- ##
==========================================
- Coverage 75.92% 66.01% -9.91%
==========================================
Files 136 38 -98
Lines 3576 974 -2602
Branches 864 266 -598
==========================================
- Hits 2715 643 -2072
+ Misses 861 331 -530
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `66.01% <ø> (-9.91%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2569?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../src/pages/User/components/LoginMethodPassword.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2569/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL2NvbXBvbmVudHMvTG9naW5NZXRob2RQYXNzd29yZC50c3g=) | `15.38% <0.00%> (-73.08%)` | :arrow_down: |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2569/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `37.70% <0.00%> (-42.63%)` | :arrow_down: |
| [web/src/components/RightContent/AvatarDropdown.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2569/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1JpZ2h0Q29udGVudC9BdmF0YXJEcm9wZG93bi50c3g=) | `50.00% <0.00%> (-32.15%)` | :arrow_down: |
| [web/src/components/PanelSection/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2569/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BhbmVsU2VjdGlvbi9pbmRleC50c3g=) | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
| [web/src/pages/Consumer/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2569/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9MaXN0LnRzeA==) | `69.44% <0.00%> (-22.23%)` | :arrow_down: |
| [...b/src/components/Plugin/UI/referer-restriction.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2569/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZWZlcmVyLXJlc3RyaWN0aW9uLnRzeA==) | `69.69% <0.00%> (-21.22%)` | :arrow_down: |
| [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2569/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | `82.35% <0.00%> (-16.48%)` | :arrow_down: |
| [web/src/components/ActionBar/ActionBar.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2569/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL0FjdGlvbkJhci9BY3Rpb25CYXIudHN4) | `69.23% <0.00%> (-15.39%)` | :arrow_down: |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2569/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `63.68% <0.00%> (-11.18%)` | :arrow_down: |
| [web/src/components/Plugin/UI/cors.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2569/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9jb3JzLnRzeA==) | `71.11% <0.00%> (-11.12%)` | :arrow_down: |
| ... and [105 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2569/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] FangSen9000 commented on pull request #2569: chore: pnpm will be an optional manager
Posted by GitBox <gi...@apache.org>.
FangSen9000 commented on PR #2569:
URL: https://github.com/apache/apisix-dashboard/pull/2569#issuecomment-1208928335
@guoqqqi @bzp2010 @Baoyuantop
When free, I hope you can give me some suggestions. The purpose of this PR is to allow local developers or users to use pnpm instead of yarn as a second option.
The document and package.json file have been changed. Lock has uploaded the latest one. You can view the changes through screenshots.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org