You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2014/04/10 12:10:24 UTC

[Bug 56380] New: comments not saved properly

https://issues.apache.org/bugzilla/show_bug.cgi?id=56380

            Bug ID: 56380
           Summary: comments not saved properly
           Product: POI
           Version: 3.10
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: HSSF
          Assignee: dev@poi.apache.org
          Reporter: elvis.ciocoiu@everlight.ro

Created attachment 31505
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31505&action=edit
unit test

If I insert more than 1023 comments in a sheet and after that save the workbook
only the last 1023 comments are persisted. I attached a test to that inserts
1025 comments. After saving the comments for the first row and the row 1023 are
not persisted.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 56380] comments not saved properly

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56380

dnlbtz@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dnlbtz@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 56380] comments not saved properly

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56380

--- Comment #3 from Nick Burch <ap...@gagravarr.org> ---
I can only suggest digging out the relevant bit of [MS-XLS] for those
record(s), and seeing if that lists any restrictions

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 56380] comments not saved properly

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56380

--- Comment #2 from Dominik Stadler <do...@gmx.at> ---
I found the culprit in HSSFComment.setShapeId(int shapeId):

However I am not sure why this is in there in the first place and what will
happen if we remove this here, need to discuss on the dev-mailing list first...

        cod.setObjectId((short) (shapeId % 1024));
        _note.setShapeId(shapeId % 1024);

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 56380] comments not saved properly

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56380

--- Comment #5 from rubensa <ru...@gmail.com> ---
The same applies to HSSFShape.setShapeId(int shapeId)

There is a 

cod.setObjectId((short) (shapeId%1024));

(that is called from HSSFComment.setShapeId(int shapeId) with
super.setShapeId(shapeId);)

Is that related with DrawingManager2 and the size of clusters?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 56380] comments not saved properly

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56380

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31505|0                           |1
        is obsolete|                            |
                 CC|                            |dominik.stadler@gmx.at

--- Comment #1 from Dominik Stadler <do...@gmx.at> ---
Created attachment 31538
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31538&action=edit
Update unit test

I have updated the unit test somewhat, but did not yet manage to find the
actual problem. BiffViewer shows the items for the comments, so it seems like
HSSF reading discards the comments somehow.

It works for up to 1024 comments, but breaks with 1025!

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 56380] comments not saved properly

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56380

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lionel.joye@renault.com

--- Comment #4 from Dominik Stadler <do...@gmx.at> ---
*** Bug 56445 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org