You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shawn Heisey (JIRA)" <ji...@apache.org> on 2013/10/13 10:17:41 UTC
[jira] [Commented] (SOLR-5342) In some places, when a caught
exception is re-thrown, the original exception is not included
[ https://issues.apache.org/jira/browse/SOLR-5342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793592#comment-13793592 ]
Shawn Heisey commented on SOLR-5342:
------------------------------------
I feel that the change to ShardHandlerFactory is necessary, but if anyone has good reason to not make the change in other classes, please let me know.
A similar issue might need to be filed in LUCENE, because I did find some similar stuff there. If nobody else does so, I will go ahead and do it when it's not 2 in the morning. :)
> In some places, when a caught exception is re-thrown, the original exception is not included
> --------------------------------------------------------------------------------------------
>
> Key: SOLR-5342
> URL: https://issues.apache.org/jira/browse/SOLR-5342
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.5
> Reporter: Shawn Heisey
> Assignee: Shawn Heisey
> Priority: Minor
> Fix For: 4.5.1, 4.6, 5.0
>
> Attachments: SOLR-5342.patch
>
>
> ShardHandlerFactory#newInstance catches exceptions and rethrows them. It was including the message from the caught exception, but not including the actual exception. This made it difficult to figure out the root cause for an SSL initialization error.
> While fixing this, I discovered other places that are missing this as well. Some of them I elected not to fix, either because it's catching IOException (which normally provides good messages), or because it was in a location that might get called frequently, which would greatly increase logging output.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org