You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/08/07 20:40:10 UTC

[GitHub] kristw commented on a change in pull request #5572: [bugfix] line_multi chart crashed on chosen (#5568)

kristw commented on a change in pull request #5572: [bugfix] line_multi chart crashed on chosen (#5568)
URL: https://github.com/apache/incubator-superset/pull/5572#discussion_r208377528
 
 

 ##########
 File path: superset/assets/src/visualizations/line_multi.js
 ##########
 @@ -26,27 +25,25 @@ export default function lineMulti(slice, payload) {
     const fdCopy = {
       ...subslice.form_data,
       filters,
-      since: fd.since,
-      until: fd.until,
+      time_range: fd.time_range,
 
 Review comment:
   The key change is this line. vs line 29-30 from previous. 
   The other changes in this file are refactor.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org