You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Monika Kachhadiya via Review Board <no...@reviews.apache.org> on 2023/09/22 18:58:36 UTC

Review Request 74620: RANGER-4394 upgrade patches to support GDS database changes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74620/
-----------------------------------------------------------

Review request for ranger, Anand Nadar, Madhan Neethiraj, Prashant Satam, and Subhrat Chaudhary.


Bugs: RANGER-4394
    https://issues.apache.org/jira/browse/RANGER-4394


Repository: ranger


Description
-------

upgrade patches to support GDS database changes
-- Tables added  x_gds_dataset, x_gds_project, x_gds_data_share, x_gds_shared_resource, x_gds_data_share_in_dataset, x_gds_dataset_in_project
-- Indexes added 
-- View added vx_principal
-- Modification of x_service and x_service_version_info for GDS
-- Perm added for Governed Data Sharing


Diffs
-----

  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 424f38d9eef3e4f7780a9755d1a79d9441e873bc 
  security-admin/db/mysql/patches/067-create-gds-tables.sql PRE-CREATION 
  security-admin/db/mysql/patches/068-create-view-principal.sql PRE-CREATION 
  security-admin/db/mysql/patches/069-add-gds-x-service.sql PRE-CREATION 
  security-admin/db/mysql/patches/070-add-gds-perm.sql PRE-CREATION 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 5ffa23f334e88ce82e64358ba9a16665db320d7e 
  security-admin/db/postgres/patches/067-create-gds-tables.sql PRE-CREATION 
  security-admin/db/postgres/patches/068-create-view-principal.sql PRE-CREATION 
  security-admin/db/postgres/patches/069-add-gds-x-service.sql PRE-CREATION 
  security-admin/db/postgres/patches/070-add-gds-perm.sql PRE-CREATION 


Diff: https://reviews.apache.org/r/74620/diff/1/


Testing
-------

Verified that the patches are executed successfully on upgrade
Verified that GDS tables are created, view for principal is created, permission for GDS is added and changes for x_service table for gds


Thanks,

Monika Kachhadiya


Re: Review Request 74620: RANGER-4394 upgrade patches to support GDS database changes

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74620/#review225860
-----------------------------------------------------------



Monika - changes to x_service and x_service_version_info have been reverted in the following commit. Please review the latest security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql and update this patch.

commit 55d2e6bfcbc02825aa5d23f38adad11f7ea1eea9
Author: Madhan Neethiraj <ma...@apache.org>
Date:   Mon Oct 2 12:15:44 2023 -0700

    RANGER-4445: new REST endpoints for dataset policies

- Madhan Neethiraj


On Oct. 13, 2023, 12:32 p.m., Monika Kachhadiya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74620/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2023, 12:32 p.m.)
> 
> 
> Review request for ranger, Anand Nadar, Madhan Neethiraj, Prashant Satam, and Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4394
>     https://issues.apache.org/jira/browse/RANGER-4394
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> upgrade patches to support GDS database changes
> -- Tables added  x_gds_dataset, x_gds_project, x_gds_data_share, x_gds_shared_resource, x_gds_data_share_in_dataset, x_gds_dataset_in_project
> -- Indexes added 
> -- View added vx_principal
> -- Modification of x_service and x_service_version_info for GDS
> -- Perm added for Governed Data Sharing
> 
> 
> Diffs
> -----
> 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 3cbca48ef 
>   security-admin/db/mysql/patches/067-create-gds-tables.sql PRE-CREATION 
>   security-admin/db/mysql/patches/068-create-view-principal.sql PRE-CREATION 
>   security-admin/db/mysql/patches/069-add-gds-x-service.sql PRE-CREATION 
>   security-admin/db/mysql/patches/070-add-gds-perm.sql PRE-CREATION 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 4cdf7e27d 
>   security-admin/db/postgres/patches/067-create-gds-tables.sql PRE-CREATION 
>   security-admin/db/postgres/patches/068-create-view-principal.sql PRE-CREATION 
>   security-admin/db/postgres/patches/069-add-gds-x-service.sql PRE-CREATION 
>   security-admin/db/postgres/patches/070-add-gds-perm.sql PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/74620/diff/2/
> 
> 
> Testing
> -------
> 
> Verified that the patches are executed successfully on upgrade
> Verified that GDS tables are created, view for principal is created, permission for GDS is added and changes for x_service table for gds
> 
> 
> Thanks,
> 
> Monika Kachhadiya
> 
>


Re: Review Request 74620: RANGER-4394 upgrade patches to support GDS database changes

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74620/#review225865
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Oct. 16, 2023, 11:22 a.m., Monika Kachhadiya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74620/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2023, 11:22 a.m.)
> 
> 
> Review request for ranger, Anand Nadar, Madhan Neethiraj, Prashant Satam, and Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4394
>     https://issues.apache.org/jira/browse/RANGER-4394
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> upgrade patches to support GDS database changes
> -- Tables added  x_gds_dataset, x_gds_project, x_gds_data_share, x_gds_shared_resource, x_gds_data_share_in_dataset, x_gds_dataset_in_project
> -- Indexes added 
> -- View added vx_principal
> -- Modification of x_service and x_service_version_info for GDS
> -- Perm added for Governed Data Sharing
> 
> 
> Diffs
> -----
> 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 3cbca48efa2b6b3b11aeb35c0d0af86d0b46a2c4 
>   security-admin/db/mysql/patches/067-create-gds-tables.sql PRE-CREATION 
>   security-admin/db/mysql/patches/068-create-view-principal.sql PRE-CREATION 
>   security-admin/db/mysql/patches/069-add-gz_json_x_security_zone.sql PRE-CREATION 
>   security-admin/db/mysql/patches/070-add-gds-perm.sql PRE-CREATION 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 4cdf7e27d68ba3faa180538eea3b2b59d6e387a0 
>   security-admin/db/postgres/patches/067-create-gds-tables.sql PRE-CREATION 
>   security-admin/db/postgres/patches/068-create-view-principal.sql PRE-CREATION 
>   security-admin/db/postgres/patches/069-add-gz_json_x_security_zone.sql PRE-CREATION 
>   security-admin/db/postgres/patches/070-add-gds-perm.sql PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/74620/diff/3/
> 
> 
> Testing
> -------
> 
> Verified that the patches are executed successfully on upgrade
> Verified that GDS tables are created, view for principal is created, permission for GDS is added and changes for x_service table for gds
> 
> 
> Thanks,
> 
> Monika Kachhadiya
> 
>


Re: Review Request 74620: RANGER-4394 upgrade patches to support GDS database changes

Posted by Monika Kachhadiya via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74620/
-----------------------------------------------------------

(Updated Oct. 16, 2023, 11:22 a.m.)


Review request for ranger, Anand Nadar, Madhan Neethiraj, Prashant Satam, and Subhrat Chaudhary.


Changes
-------

added patch for gz_jsonData column addition in x_security_zone and removed patch for x_service


Bugs: RANGER-4394
    https://issues.apache.org/jira/browse/RANGER-4394


Repository: ranger


Description
-------

upgrade patches to support GDS database changes
-- Tables added  x_gds_dataset, x_gds_project, x_gds_data_share, x_gds_shared_resource, x_gds_data_share_in_dataset, x_gds_dataset_in_project
-- Indexes added 
-- View added vx_principal
-- Modification of x_service and x_service_version_info for GDS
-- Perm added for Governed Data Sharing


Diffs (updated)
-----

  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 3cbca48efa2b6b3b11aeb35c0d0af86d0b46a2c4 
  security-admin/db/mysql/patches/067-create-gds-tables.sql PRE-CREATION 
  security-admin/db/mysql/patches/068-create-view-principal.sql PRE-CREATION 
  security-admin/db/mysql/patches/069-add-gz_json_x_security_zone.sql PRE-CREATION 
  security-admin/db/mysql/patches/070-add-gds-perm.sql PRE-CREATION 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 4cdf7e27d68ba3faa180538eea3b2b59d6e387a0 
  security-admin/db/postgres/patches/067-create-gds-tables.sql PRE-CREATION 
  security-admin/db/postgres/patches/068-create-view-principal.sql PRE-CREATION 
  security-admin/db/postgres/patches/069-add-gz_json_x_security_zone.sql PRE-CREATION 
  security-admin/db/postgres/patches/070-add-gds-perm.sql PRE-CREATION 


Diff: https://reviews.apache.org/r/74620/diff/3/

Changes: https://reviews.apache.org/r/74620/diff/2-3/


Testing
-------

Verified that the patches are executed successfully on upgrade
Verified that GDS tables are created, view for principal is created, permission for GDS is added and changes for x_service table for gds


Thanks,

Monika Kachhadiya


Re: Review Request 74620: RANGER-4394 upgrade patches to support GDS database changes

Posted by Monika Kachhadiya via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74620/
-----------------------------------------------------------

(Updated Oct. 13, 2023, 12:32 p.m.)


Review request for ranger, Anand Nadar, Madhan Neethiraj, Prashant Satam, and Subhrat Chaudhary.


Bugs: RANGER-4394
    https://issues.apache.org/jira/browse/RANGER-4394


Repository: ranger


Description
-------

upgrade patches to support GDS database changes
-- Tables added  x_gds_dataset, x_gds_project, x_gds_data_share, x_gds_shared_resource, x_gds_data_share_in_dataset, x_gds_dataset_in_project
-- Indexes added 
-- View added vx_principal
-- Modification of x_service and x_service_version_info for GDS
-- Perm added for Governed Data Sharing


Diffs (updated)
-----

  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 3cbca48ef 
  security-admin/db/mysql/patches/067-create-gds-tables.sql PRE-CREATION 
  security-admin/db/mysql/patches/068-create-view-principal.sql PRE-CREATION 
  security-admin/db/mysql/patches/069-add-gds-x-service.sql PRE-CREATION 
  security-admin/db/mysql/patches/070-add-gds-perm.sql PRE-CREATION 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 4cdf7e27d 
  security-admin/db/postgres/patches/067-create-gds-tables.sql PRE-CREATION 
  security-admin/db/postgres/patches/068-create-view-principal.sql PRE-CREATION 
  security-admin/db/postgres/patches/069-add-gds-x-service.sql PRE-CREATION 
  security-admin/db/postgres/patches/070-add-gds-perm.sql PRE-CREATION 


Diff: https://reviews.apache.org/r/74620/diff/2/

Changes: https://reviews.apache.org/r/74620/diff/1-2/


Testing
-------

Verified that the patches are executed successfully on upgrade
Verified that GDS tables are created, view for principal is created, permission for GDS is added and changes for x_service table for gds


Thanks,

Monika Kachhadiya