You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/12/27 21:42:41 UTC
[GitHub] [trafficcontrol] ZugNZwang opened a new issue #4240: Can update a
user's username to contain spaces
ZugNZwang opened a new issue #4240: Can update a user's username to contain spaces
URL: https://github.com/apache/trafficcontrol/issues/4240
<!--
************ STOP!! ************
If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
<!--
- For *SUPPORT QUESTIONS*, use the
[Traffic Control slack channels](https://traffic-control-cdn.slack.com) or [Traffic Control mailing lists](http://trafficcontrol.apache.org/mailing_lists/).
- Before submitting, please **SEARCH GITHUB** for a similar issue or PR. -->
## I'm submitting a ...
<!-- (check all that apply with "[x]") -->
<!--- security vulnerability (STOP!! - see above)-->
- [X] bug report
- [ ] new feature / enhancement request
- [ ] improvement request (usability, performance, tech debt, etc.)
- [ ] other <!--(Please do not submit support requests here - see above)-->
## Traffic Control components affected ...
<!-- (check all that apply with "[x]") -->
- [ ] CDN in a Box
- [ ] Documentation
- [ ] Grove
- [ ] Traffic Control Client
- [ ] Traffic Monitor
- [X] Traffic Ops
- [ ] Traffic Ops ORT
- [ ] Traffic Portal
- [ ] Traffic Router
- [ ] Traffic Stats
- [ ] Traffic Vault
- [ ] unknown
## Current behavior:
<!-- Describe how the bug manifests / how the current features are insufficient. -->
When making a `PUT` request to `/user/current` with the following request body:
```
{
"user": {
"username": "space test"
}
}
```
The response returned is:
```
HTTP/1.1 200 OK
{
"alerts": [
{
"text": "User profile was successfully updated",
"level": "success"
}
],
"response": {
"username": "space test",
.
.
}
}
```
## Expected / new behavior:
<!-- Describe what the behavior would be without the bug / how the feature would improve Traffic Control -->
Should not be allowed to update a username that contains spaces.
Should return:
```
HTTP/1.1 400 Bad Request
{
"alerts": [
{
"text": "Couldn't parse request: username: cannot contain spaces",
"level": "error"
}
]
}
```
## Minimal reproduction of the problem with instructions:
<!--
If the current behavior is a bug or you can illustrate your feature request better with an example,
please provide the *STEPS TO REPRODUCE* and include the applicable TC version.
-->
## Anything else:
<!-- e.g. stacktraces, related issues, suggestions how to fix -->
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] ocket8888 commented on issue #4240: Can update a
user's username to contain spaces
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #4240: Can update a user's username to contain spaces
URL: https://github.com/apache/trafficcontrol/issues/4240#issuecomment-579854649
Whoops, that PR referenced the wrong Issue. This is still open.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mitchell852 closed issue #4240: Can update a
user's username to contain spaces
Posted by GitBox <gi...@apache.org>.
mitchell852 closed issue #4240: Can update a user's username to contain spaces
URL: https://github.com/apache/trafficcontrol/issues/4240
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] ZugNZwang opened a new issue #4240: Can update a
user's username to contain spaces
Posted by GitBox <gi...@apache.org>.
ZugNZwang opened a new issue #4240: Can update a user's username to contain spaces
URL: https://github.com/apache/trafficcontrol/issues/4240
<!--
************ STOP!! ************
If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
<!--
- For *SUPPORT QUESTIONS*, use the
[Traffic Control slack channels](https://traffic-control-cdn.slack.com) or [Traffic Control mailing lists](http://trafficcontrol.apache.org/mailing_lists/).
- Before submitting, please **SEARCH GITHUB** for a similar issue or PR. -->
## I'm submitting a ...
<!-- (check all that apply with "[x]") -->
<!--- security vulnerability (STOP!! - see above)-->
- [X] bug report
- [ ] new feature / enhancement request
- [ ] improvement request (usability, performance, tech debt, etc.)
- [ ] other <!--(Please do not submit support requests here - see above)-->
## Traffic Control components affected ...
<!-- (check all that apply with "[x]") -->
- [ ] CDN in a Box
- [ ] Documentation
- [ ] Grove
- [ ] Traffic Control Client
- [ ] Traffic Monitor
- [ ] Traffic Ops
- [ ] Traffic Ops ORT
- [x] Traffic Portal
- [ ] Traffic Router
- [ ] Traffic Stats
- [ ] Traffic Vault
- [ ] unknown
## Current behavior:
<!-- Describe how the bug manifests / how the current features are insufficient. -->
When making a `PUT` request to `/user/current` with the following request body:
```
{
"user": {
"username": "space test"
}
}
```
The response returned is:
```
HTTP/1.1 200 OK
{
"alerts": [
{
"text": "User profile was successfully updated",
"level": "success"
}
],
"response": {
"username": "space test",
.
.
}
}
```
## Expected / new behavior:
<!-- Describe what the behavior would be without the bug / how the feature would improve Traffic Control -->
Should not be allowed to update a username that contains spaces.
Should return:
```
HTTP/1.1 400 Bad Request
{
"alerts": [
{
"text": "Couldn't parse request: username: cannot contain spaces",
"level": "error"
}
]
}
```
## Minimal reproduction of the problem with instructions:
<!--
If the current behavior is a bug or you can illustrate your feature request better with an example,
please provide the *STEPS TO REPRODUCE* and include the applicable TC version.
-->
## Anything else:
<!-- e.g. stacktraces, related issues, suggestions how to fix -->
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #4240: Can
update a user's username to contain spaces
Posted by GitBox <gi...@apache.org>.
mitchell852 edited a comment on issue #4240: Can update a user's username to contain spaces
URL: https://github.com/apache/trafficcontrol/issues/4240#issuecomment-569722238
trying to think if a username with spaces would cause problems. is it weird? yes. does it cause real problems? not sure. so not sure whether to mark this as a bug or improvement or "works as designed".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mitchell852 commented on issue #4240: Can update a
user's username to contain spaces
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4240: Can update a user's username to contain spaces
URL: https://github.com/apache/trafficcontrol/issues/4240#issuecomment-569722238
trying to think if a username with spaces would cause problems. is it weird? yes. does it cause real problems? not sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mitchell852 commented on issue #4240: Can update a
user's username to contain spaces
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4240: Can update a user's username to contain spaces
URL: https://github.com/apache/trafficcontrol/issues/4240#issuecomment-570609010
@ocket8888 - maybe rather than closing this, it should be reopened and the "fix" is to make TP and the TO API consistent. Meaning that TP should allow spaces as well. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] ocket8888 commented on issue #4240: Can update a
user's username to contain spaces
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #4240: Can update a user's username to contain spaces
URL: https://github.com/apache/trafficcontrol/issues/4240#issuecomment-570618552
Yeah, that sounds appropriate to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] ocket8888 closed issue #4240: Can update a user's
username to contain spaces
Posted by GitBox <gi...@apache.org>.
ocket8888 closed issue #4240: Can update a user's username to contain spaces
URL: https://github.com/apache/trafficcontrol/issues/4240
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] ZugNZwang opened a new issue #4240: Can update a
user's username to contain spaces
Posted by GitBox <gi...@apache.org>.
ZugNZwang opened a new issue #4240: Can update a user's username to contain spaces
URL: https://github.com/apache/trafficcontrol/issues/4240
<!--
************ STOP!! ************
If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
<!--
- For *SUPPORT QUESTIONS*, use the
[Traffic Control slack channels](https://traffic-control-cdn.slack.com) or [Traffic Control mailing lists](http://trafficcontrol.apache.org/mailing_lists/).
- Before submitting, please **SEARCH GITHUB** for a similar issue or PR. -->
## I'm submitting a ...
<!-- (check all that apply with "[x]") -->
<!--- security vulnerability (STOP!! - see above)-->
- [X] bug report
- [ ] new feature / enhancement request
- [ ] improvement request (usability, performance, tech debt, etc.)
- [ ] other <!--(Please do not submit support requests here - see above)-->
## Traffic Control components affected ...
<!-- (check all that apply with "[x]") -->
- [ ] CDN in a Box
- [ ] Documentation
- [ ] Grove
- [ ] Traffic Control Client
- [ ] Traffic Monitor
- [X] Traffic Ops
- [ ] Traffic Ops ORT
- [ ] Traffic Portal
- [ ] Traffic Router
- [ ] Traffic Stats
- [ ] Traffic Vault
- [ ] unknown
## Current behavior:
<!-- Describe how the bug manifests / how the current features are insufficient. -->
When making a `PUT` request to `/user/current` with the following request body:
```
{
"user": {
"username": "space test"
}
}
```
The response returned is:
```
HTTP/1.1 200 OK
{
"alerts": [
{
"text": "User profile was successfully updated",
"level": "success"
}
],
"response": {
"username": "space test",
.
.
}
}
```
## Expected / new behavior:
<!-- Describe what the behavior would be without the bug / how the feature would improve Traffic Control -->
Should not be allowed to update a username that contains spaces.
Should return:
```
HTTP/1.1 400 Bad Request
{
"alerts": [
{
"text": "Couldn't parse request: username: cannot contain spaces",
"level": "error"
}
]
}
```
## Minimal reproduction of the problem with instructions:
<!--
If the current behavior is a bug or you can illustrate your feature request better with an example,
please provide the *STEPS TO REPRODUCE* and include the applicable TC version.
-->
## Anything else:
<!-- e.g. stacktraces, related issues, suggestions how to fix -->
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] ocket8888 commented on issue #4240: Can update a
user's username to contain spaces
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #4240: Can update a user's username to contain spaces
URL: https://github.com/apache/trafficcontrol/issues/4240#issuecomment-570335395
Yeah, the Perl would let you do that and you can also create users with spaces in their username. I think this is so far "works as designed".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] ocket8888 commented on issue #4240: Can update a
user's username to contain spaces
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #4240: Can update a user's username to contain spaces
URL: https://github.com/apache/trafficcontrol/issues/4240#issuecomment-570025767
I think you can also create a user having a username with spaces, though the TP form doesn't like it. In any case I think changing this would break compatibility with the Perl; that is, if memory serves. I can check in a day or two to be sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services