You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/11/15 04:48:16 UTC

[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #12897: [fix-12870][server] fix NPE while retry task

ruanwenjun commented on code in PR #12897:
URL: https://github.com/apache/dolphinscheduler/pull/12897#discussion_r1022314242


##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java:
##########
@@ -477,6 +477,8 @@ private void retryTaskInstance(TaskInstance taskInstance) throws StateEventHandl
                     taskInstance.getId());
             return;
         }
+        // retry set task id
+        newTaskInstance.setId(taskInstance.getId());

Review Comment:
   You can not set the id here, this may cause the task instance cannot insert.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org