[GitHub] [geode-native] pdxcodemonkey opened pull request #360: GEODE-5259: Fix clang (xcode 10) build breaks

["pdxcodemonkey (GitHub)" <gi...@apache.org>]

- Remove problematic clang-format options
- Anonymize unused parameters
- Remove unnecessary type cast

[ Full content available at: https://github.com/apache/geode-native/pull/360 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] echobravopapa commented on pull request #360: GEODE-5259: Fix clang (xcode 10) build breaks

["echobravopapa (GitHub)" <gi...@apache.org>]

I think a more complete refactor for this `metadataEqualTo` is in order... look at the call site of this method and let's think about if `DataSerializables` have meta data for comparison, maybe it all just gets removed...?  and we'll want a test to drive out the change in any case as there was not legit coverage for the previous change.

[ Full content available at: https://github.com/apache/geode-native/pull/360 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pdxcodemonkey closed pull request #360: GEODE-5259: Fix clang (xcode 10) build breaks

["pdxcodemonkey (GitHub)" <gi...@apache.org>]

[ pull request closed by pdxcodemonkey ]

[ Full content available at: https://github.com/apache/geode-native/pull/360 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #360: GEODE-5259: Fix clang (xcode 10) build breaks

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

The other `DataSerializable`* have metadata to compare. Rather than rewriting the common bits of the comparison in each type we use this template class to do the compare. At compile time this results in a no-op for the `DataSerializableInternal`.

[ Full content available at: https://github.com/apache/geode-native/pull/360 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org