[GitHub] [maven-shade-plugin] nielsbasjes commented on pull request #26: [MSHADE-326] Hide shaded dependencies from the rest of the reactor build

[GitBox <gi...@apache.org>]

nielsbasjes commented on pull request #26:
URL: https://github.com/apache/maven-shade-plugin/pull/26#issuecomment-873028644


   Just to clarify the current status as I understand it:
   
   1. https://github.com/apache/maven/pull/483 
       fixes the real problem in Maven itself.
   2. https://github.com/apache/maven-shade-plugin/pull/103 
       fixes the MSHADE-340 test that fails under the changed maven.
   3. https://github.com/apache/maven-shade-plugin/pull/26 
       is essentially reduced to a new integration test that only verifies if everything now works correctly. 
       So this will only pass with a "fixed" maven version.
   
   One thing that worries me right now is the potential impact of existing projects.
   The need for a fix in the above mentioned test is a clear indicator that there will be cases this can cause problems.
   
   I do not know if this is a significant impact or just that existing configuration problems now surface.
   
   @michael-o @rfscholte is there anything additional I can do to help make all of this a success?
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org