You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/05 08:27:19 UTC

[GitHub] [shardingsphere] taojintianxia commented on a diff in pull request #17333: Refactor fixture of sharding-distsql-handler

taojintianxia commented on code in PR #17333:
URL: https://github.com/apache/shardingsphere/pull/17333#discussion_r865666430


##########
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/main/java/org/apache/shardingsphere/sharding/algorithm/sharding/datetime/AutoIntervalShardingAlgorithm.java:
##########
@@ -54,12 +54,12 @@ public final class AutoIntervalShardingAlgorithm implements StandardShardingAlgo
     @Setter
     private Properties props;
     
-    private LocalDateTime dateTimeLower;
+    private volatile LocalDateTime dateTimeLower;

Review Comment:
   why use keyword `volatile` for these variables.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org