[jira] [Commented] (IMPALA-11416) SlotRef::tuple_is_nullable_ uninitialised for struct children

["Daniel Becker (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-11416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562624#comment-17562624 ] 

Daniel Becker commented on IMPALA-11416:
----------------------------------------

As far as I know, tuples of struct slots cannot be nullable, so we should initialise {{tuple_is_nullable_}} to {{false}}.
Please correct me if I'm wrong.

> SlotRef::tuple_is_nullable_ uninitialised for struct children
> -------------------------------------------------------------
>
>                 Key: IMPALA-11416
>                 URL: https://issues.apache.org/jira/browse/IMPALA-11416
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>            Reporter: Daniel Becker
>            Assignee: Daniel Becker
>            Priority: Major
>
> In {{SlotRef::Init}}, {{tuple_is_nullable_}} is only assigned a value if the {{SlotRef}} is not within a struct:
> {code:cpp}
> if (!slot_desc_->parent()->isTupleOfStructSlot()) {
>       tuple_is_nullable_ = row_desc.TupleIsNullable(tuple_idx_);
> }
> {code}
> https://github.com/apache/impala/blob/fefb9f24be1f99ac0077a8d6ef00834d8e90ef45/be/src/exprs/slot-ref.cc#L103
> Otherwise {{tuple_is_nullable_}} remains uninitialised, leading to undefined behaviour when it is read.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org