You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/12/10 18:15:16 UTC
[GitHub] [iceberg] rymurr opened a new pull request #1905: Remove sun's jersey
rymurr opened a new pull request #1905:
URL: https://github.com/apache/iceberg/pull/1905
Noticed some weird `java.lang.AbstractMethodError` exceptions while using Iceberg/Hive and REST clients. This completely removes rather old versions of Jersey from all modules
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #1905: Remove sun's jersey
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #1905:
URL: https://github.com/apache/iceberg/pull/1905
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1905: Remove sun's jersey
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1905:
URL: https://github.com/apache/iceberg/pull/1905#issuecomment-743328900
> I could take a more subtle approach and add an exclude for each test dependency if you prefer.
As long as this is test, I think it's okay to be less subtle.
Sounds like this is safe and straightforward. I do worry a bit about what the runtime issues might be, so let's make sure that whatever might conflict is relocated in our runtime Jars.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rymurr commented on pull request #1905: Remove sun's jersey
Posted by GitBox <gi...@apache.org>.
rymurr commented on pull request #1905:
URL: https://github.com/apache/iceberg/pull/1905#issuecomment-743186804
Hey @rdblue
Sorry, more info:
1. `com.sun.jersey` is only in test dependencies for the various spark/hive/flink/mr modules. Basically anywhere we user hadoop 2.7 libs. So this doesn't affect runtime.
2. This occurs anywhere you try and use newer `javax.ws.rs` packages as Jersey1.9 sneakily has overlapping pacakges in `com.sun.jersey:jersey-client`. So i have seen this specifically when working w/ Nessie and Spark or Hive tests (in the iceberg repo or the Nessie repo). The Nessie client loads `javax` packages and hits a variation on `java.lang.AbstractMethodError: javax.ws.rs.core.UriBuilder.uri(Ljava/lang/String;)Ljavax/ws/rs/core/UriBuilder;`. This is a pre-cursor patch to some fixes to allow Nessie as a custom catalog in the hive reader.
A quick check shows that Spark doesn't ship this old jersey (even though its a dep of hadoop 2.7) nor do some Hives.
From my understanding the only thing this change does is allow us to use modern REST clients from unit tests and it will have no effect on runtime. I could take a more subtle approach and add an exclude for each test dependency if you prefer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1905: Remove sun's jersey
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1905:
URL: https://github.com/apache/iceberg/pull/1905#issuecomment-742809546
Do you have more information about what was happening? I don't think that we include Jersey in any runtime Jars, so this shouldn't affect runtime. Where did you see the error?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org