You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by pietermartin <gi...@git.apache.org> on 2015/10/24 11:23:15 UTC
[GitHub] incubator-tinkerpop pull request: Getters for RepeatStep.emitTrave...
GitHub user pietermartin opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/119
Getters for RepeatStep.emitTraversal / untilTraversal and LoopTraversal.maxLoops
These getters are required for providers to access the state of the RepeatStep when optimizing it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pietermartin/incubator-tinkerpop master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/119.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #119
----
commit 5bf1574504b57fe6124c4ba7475f21970d64ba30
Author: pieter <pi...@gmail.com>
Date: 2015-10-24T09:12:05Z
Add getters for RepeatStep.emitTraversal and RepeatStep.untilTraversal.
This is primarily for providers to be able to interrogate the state of the RepeatStep.
commit f39ea35b1151a7f273a03568627a2ef9d69f1832
Author: pieter <pi...@gmail.com>
Date: 2015-10-24T09:13:33Z
Added a getter for LoopTraversal.maxLoops.
Providers need to access the number of loops when optimizing the RepeatStep.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Getters for RepeatStep.emitTrave...
Posted by pietermartin <gi...@git.apache.org>.
Github user pietermartin commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/119#issuecomment-150807894
This PR is for https://issues.apache.org/jira/browse/TINKERPOP3-907
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Getters for RepeatStep.emitTrave...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/119#issuecomment-150831259
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Getters for RepeatStep.emitTrave...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/119
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Getters for RepeatStep.emitTrave...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/119#issuecomment-150923772
+1
RESULT: +1 (3) - i'll do the merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Getters for RepeatStep.emitTrave...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/119#issuecomment-150828153
This looks good to me. Simple getters added.
VOTE +1.
@pietermartin --- you are really introspecting deep into the traversal. Note that we have yet to publish the virtual machine step library and thus, things like `LoopTraversal` may not be in the specification. Thus, we can't guarantee you stability of the API in this area. Just a heads up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Getters for RepeatStep.emitTrave...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/119#issuecomment-150926093
Thanks for the PR @pietermartin - merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---