You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Padma Priya N <pa...@gmail.com> on 2017/01/18 07:15:38 UTC
Review Request 55664: AMBARI-19602:Input logic tags are missing in the
coordinator xml
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55664/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
Bugs: AMBARI-19602
https://issues.apache.org/jira/browse/AMBARI-19602
Repository: ambari
Description
-------
'Input-logic' tags are missing in the coordinator xml.
Steps to reproduce :
1) Import a coordinator xml with input logic
2) Preview the xml.
3) Check that 'input-logic' tags which are available in original xml are missing in the preview xml.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js eb0d585
contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 0979c25
contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js 9b54495
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs f906fd5
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs b33420a
Diff: https://reviews.apache.org/r/55664/diff/
Testing
-------
Manual Testing
Thanks,
Padma Priya N
Re: Review Request 55664: AMBARI-19602:Input logic tags are missing
in the coordinator xml
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55664/#review162069
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Jan. 18, 2017, 7:15 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55664/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 7:15 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-19602
> https://issues.apache.org/jira/browse/AMBARI-19602
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 'Input-logic' tags are missing in the coordinator xml.
> Steps to reproduce :
> 1) Import a coordinator xml with input logic
> 2) Preview the xml.
> 3) Check that 'input-logic' tags which are available in original xml are missing in the preview xml.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js eb0d585
> contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 0979c25
> contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js 9b54495
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs f906fd5
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs b33420a
>
> Diff: https://reviews.apache.org/r/55664/diff/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>
Re: Review Request 55664: AMBARI-19602:Input logic tags are missing
in the coordinator xml
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55664/#review162039
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On Jan. 18, 2017, 7:15 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55664/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 7:15 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-19602
> https://issues.apache.org/jira/browse/AMBARI-19602
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 'Input-logic' tags are missing in the coordinator xml.
> Steps to reproduce :
> 1) Import a coordinator xml with input logic
> 2) Preview the xml.
> 3) Check that 'input-logic' tags which are available in original xml are missing in the preview xml.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js eb0d585
> contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 0979c25
> contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js 9b54495
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs f906fd5
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs b33420a
>
> Diff: https://reviews.apache.org/r/55664/diff/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>
Re: Review Request 55664: AMBARI-19602:Input logic tags are missing
in the coordinator xml
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55664/#review162037
-----------------------------------------------------------
Ship it!
Ship It!
- Nitiraj Rathore
On Jan. 18, 2017, 7:15 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55664/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 7:15 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-19602
> https://issues.apache.org/jira/browse/AMBARI-19602
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 'Input-logic' tags are missing in the coordinator xml.
> Steps to reproduce :
> 1) Import a coordinator xml with input logic
> 2) Preview the xml.
> 3) Check that 'input-logic' tags which are available in original xml are missing in the preview xml.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js eb0d585
> contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 0979c25
> contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js 9b54495
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs f906fd5
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs b33420a
>
> Diff: https://reviews.apache.org/r/55664/diff/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>