You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/22 19:03:08 UTC

[GitHub] [beam] kennknowles commented on a diff in pull request #22289: Fix overly aggressive null check in RowWriterFactory

kennknowles commented on code in PR #22289:
URL: https://github.com/apache/beam/pull/22289#discussion_r927920479


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/RowWriterFactory.java:
##########
@@ -135,10 +136,12 @@ BigQueryRowWriter<ElementT> createRowWriter(String tempFilePrefix, DestinationT
         throw new IllegalStateException(
             "createRowWriter called when schemaFactory is null; forgot to call prepare()?");
       }
+      @SuppressWarnings({

Review Comment:
   Do not suppress the warning, but rather follow through the consequences of allowing null here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org