You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/24 16:53:24 UTC

[GitHub] [flink] StephanEwen commented on pull request #13233: [FLINK-19040][task] Close SourceReader in SourceOperator

StephanEwen commented on pull request #13233:
URL: https://github.com/apache/flink/pull/13233#issuecomment-679245209


   Looks good to me, too.
   
   Minor comment: I think it is fine to not put the `close()` in a `finally` block in tests, if this makes the test structure a bit more complex, because we don't need to ensure clean shutdown on unexpected test failures.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org