[GitHub] [beam] pabloem commented on a diff in pull request #25236: SpannerIO: parameterizing partitionQuery timeout

["pabloem (via GitHub)" <gi...@apache.org>]

pabloem commented on code in PR #25236:
URL: https://github.com/apache/beam/pull/25236#discussion_r1107381512


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerConfig.java:
##########
@@ -265,4 +273,24 @@ public SpannerConfig withRpcPriority(ValueProvider<RpcPriority> rpcPriority) {
   public SpannerConfig withDatabaseRole(ValueProvider<String> databaseRole) {
     return toBuilder().setDatabaseRole(databaseRole).build();
   }
+
+  /** Specifies the PartitionQuery timeout. */
+  public SpannerConfig withPartitionQueryTimeout(Duration partitionQueryTimeout) {
+    return withPartitionQueryTimeout(ValueProvider.StaticValueProvider.of(partitionQueryTimeout));
+  }
+
+  /** Specifies the PartitionQuery timeout. */
+  public SpannerConfig withPartitionQueryTimeout(ValueProvider<Duration> partitionQueryTimeout) {
+    return toBuilder().setPartitionQueryTimeout(partitionQueryTimeout).build();
+  }

Review Comment:
   avoid this. Just pass the Duration parameter directly. (ditto for others)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org