You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by Paul Guo <pa...@gmail.com> on 2016/07/12 03:32:36 UTC
About *.out files in test/feature
I'd mask the output files after running feature tests in .gitignore and
clean it up after running "make clean" or "make distclean". Anyone has any
suggestions? Thanks.
diff --git a/src/test/feature/.gitignore b/src/test/feature/.gitignore
index a2e6bd4..c7332b2 100644
--- a/src/test/feature/.gitignore
+++ b/src/test/feature/.gitignore
@@ -1 +1,2 @@
doc/
+**/*.out
diff --git a/src/test/feature/Makefile b/src/test/feature/Makefile
index adc6acc..e0985d1 100644
--- a/src/test/feature/Makefile
+++ b/src/test/feature/Makefile
@@ -35,6 +35,7 @@ doc:
doxygen doxygen_template
clean distclean: sharelibclean
+ find . -type f -name "*.out" |xargs rm -f
$(RM) feature-test
$(RM) feature-test.dSYM
Re: About *.out files in test/feature
Posted by Paul Guo <pa...@gmail.com>.
I have thought about removing git-cloned repository after "make distclean",
however considering git-clone is really time-consuming for some large
project,
I did not adopt the idea.
2016-07-12 12:18 GMT+08:00 Hong Wu <xu...@gmail.com>:
> BTW, since the make system is a little tricky in HAWQ, I think `make
> distclean` should also delete third-party libraries cloned during "make"
> such as orca and so on.
>
> In conclusion, `make` should delete files generated from compiling. `make
> distclean` should return back to the original codebase to users as it was
> cloned.
>
> Best
> xunzhang
>
> 2016-07-12 11:57 GMT+08:00 Gmail <xu...@gmail.com>:
>
> > I agree with ruilong.
> > Make clean should clean files generated only in make process.
> >
> > Make distclean should clean files generated in make and configure
> process.
> >
> > xunzhang
> > Send from my iPhone
> >
> >
> >
> > 发自我的 iPhone
> > > 在 2016年7月12日，11:40，Ruilong Huo <rh...@pivotal.io> 写道：
> > >
> > > I think "make clean" should only clean the files generated during
> compile
> > > process.
> > > The *.out files are created by feature test code with psql, so I would
> > > prefer keep them.
> > > If you would like to clean them, that should be in feature test
> > framework,
> > > not in makefile.
> > >
> > > Any comments?
> > >
> > > Best regards,
> > > Ruilong Huo
> > >
> > >> On Tue, Jul 12, 2016 at 11:37 AM, Xiang Sheng <xs...@pivotal.io>
> > wrote:
> > >>
> > >> We indeed should delete these useless files after runing make clean or
> > make
> > >> distclean.
> > >>
> > >>> On Tue, Jul 12, 2016 at 11:35 AM, Ming Li <ml...@pivotal.io> wrote:
> > >>>
> > >>> LGTM. +1.
> > >>>
> > >>>> On Tue, Jul 12, 2016 at 11:32 AM, Paul Guo <pa...@gmail.com>
> wrote:
> > >>>>
> > >>>> I'd mask the output files after running feature tests in .gitignore
> > and
> > >>>> clean it up after running "make clean" or "make distclean". Anyone
> has
> > >>> any
> > >>>> suggestions? Thanks.
> > >>>>
> > >>>> diff --git a/src/test/feature/.gitignore
> b/src/test/feature/.gitignore
> > >>>> index a2e6bd4..c7332b2 100644
> > >>>> --- a/src/test/feature/.gitignore
> > >>>> +++ b/src/test/feature/.gitignore
> > >>>> @@ -1 +1,2 @@
> > >>>> doc/
> > >>>> +**/*.out
> > >>>>
> > >>>> diff --git a/src/test/feature/Makefile b/src/test/feature/Makefile
> > >>>> index adc6acc..e0985d1 100644
> > >>>> --- a/src/test/feature/Makefile
> > >>>> +++ b/src/test/feature/Makefile
> > >>>> @@ -35,6 +35,7 @@ doc:
> > >>>> doxygen doxygen_template
> > >>>>
> > >>>> clean distclean: sharelibclean
> > >>>> + find . -type f -name "*.out" |xargs rm -f
> > >>>> $(RM) feature-test
> > >>>> $(RM) feature-test.dSYM
> > >>
> > >>
> > >>
> > >> --
> > >> Best Regards,
> > >> Xiang Sheng
> > >>
> >
>
Re: About *.out files in test/feature
Posted by Wen Lin <wl...@pivotal.io>.
Very cool!
On Tue, Jul 12, 2016 at 12:18 PM, Hong Wu <xu...@gmail.com> wrote:
> BTW, since the make system is a little tricky in HAWQ, I think `make
> distclean` should also delete third-party libraries cloned during "make"
> such as orca and so on.
>
> In conclusion, `make` should delete files generated from compiling. `make
> distclean` should return back to the original codebase to users as it was
> cloned.
>
> Best
> xunzhang
>
> 2016-07-12 11:57 GMT+08:00 Gmail <xu...@gmail.com>:
>
> > I agree with ruilong.
> > Make clean should clean files generated only in make process.
> >
> > Make distclean should clean files generated in make and configure
> process.
> >
> > xunzhang
> > Send from my iPhone
> >
> >
> >
> > 发自我的 iPhone
> > > 在 2016年7月12日，11:40，Ruilong Huo <rh...@pivotal.io> 写道：
> > >
> > > I think "make clean" should only clean the files generated during
> compile
> > > process.
> > > The *.out files are created by feature test code with psql, so I would
> > > prefer keep them.
> > > If you would like to clean them, that should be in feature test
> > framework,
> > > not in makefile.
> > >
> > > Any comments?
> > >
> > > Best regards,
> > > Ruilong Huo
> > >
> > >> On Tue, Jul 12, 2016 at 11:37 AM, Xiang Sheng <xs...@pivotal.io>
> > wrote:
> > >>
> > >> We indeed should delete these useless files after runing make clean or
> > make
> > >> distclean.
> > >>
> > >>> On Tue, Jul 12, 2016 at 11:35 AM, Ming Li <ml...@pivotal.io> wrote:
> > >>>
> > >>> LGTM. +1.
> > >>>
> > >>>> On Tue, Jul 12, 2016 at 11:32 AM, Paul Guo <pa...@gmail.com>
> wrote:
> > >>>>
> > >>>> I'd mask the output files after running feature tests in .gitignore
> > and
> > >>>> clean it up after running "make clean" or "make distclean". Anyone
> has
> > >>> any
> > >>>> suggestions? Thanks.
> > >>>>
> > >>>> diff --git a/src/test/feature/.gitignore
> b/src/test/feature/.gitignore
> > >>>> index a2e6bd4..c7332b2 100644
> > >>>> --- a/src/test/feature/.gitignore
> > >>>> +++ b/src/test/feature/.gitignore
> > >>>> @@ -1 +1,2 @@
> > >>>> doc/
> > >>>> +**/*.out
> > >>>>
> > >>>> diff --git a/src/test/feature/Makefile b/src/test/feature/Makefile
> > >>>> index adc6acc..e0985d1 100644
> > >>>> --- a/src/test/feature/Makefile
> > >>>> +++ b/src/test/feature/Makefile
> > >>>> @@ -35,6 +35,7 @@ doc:
> > >>>> doxygen doxygen_template
> > >>>>
> > >>>> clean distclean: sharelibclean
> > >>>> + find . -type f -name "*.out" |xargs rm -f
> > >>>> $(RM) feature-test
> > >>>> $(RM) feature-test.dSYM
> > >>
> > >>
> > >>
> > >> --
> > >> Best Regards,
> > >> Xiang Sheng
> > >>
> >
>
Re: About *.out files in test/feature
Posted by Hong Wu <xu...@gmail.com>.
BTW, since the make system is a little tricky in HAWQ, I think `make
distclean` should also delete third-party libraries cloned during "make"
such as orca and so on.
In conclusion, `make` should delete files generated from compiling. `make
distclean` should return back to the original codebase to users as it was
cloned.
Best
xunzhang
2016-07-12 11:57 GMT+08:00 Gmail <xu...@gmail.com>:
> I agree with ruilong.
> Make clean should clean files generated only in make process.
>
> Make distclean should clean files generated in make and configure process.
>
> xunzhang
> Send from my iPhone
>
>
>
> 发自我的 iPhone
> > 在 2016年7月12日，11:40，Ruilong Huo <rh...@pivotal.io> 写道：
> >
> > I think "make clean" should only clean the files generated during compile
> > process.
> > The *.out files are created by feature test code with psql, so I would
> > prefer keep them.
> > If you would like to clean them, that should be in feature test
> framework,
> > not in makefile.
> >
> > Any comments?
> >
> > Best regards,
> > Ruilong Huo
> >
> >> On Tue, Jul 12, 2016 at 11:37 AM, Xiang Sheng <xs...@pivotal.io>
> wrote:
> >>
> >> We indeed should delete these useless files after runing make clean or
> make
> >> distclean.
> >>
> >>> On Tue, Jul 12, 2016 at 11:35 AM, Ming Li <ml...@pivotal.io> wrote:
> >>>
> >>> LGTM. +1.
> >>>
> >>>> On Tue, Jul 12, 2016 at 11:32 AM, Paul Guo <pa...@gmail.com> wrote:
> >>>>
> >>>> I'd mask the output files after running feature tests in .gitignore
> and
> >>>> clean it up after running "make clean" or "make distclean". Anyone has
> >>> any
> >>>> suggestions? Thanks.
> >>>>
> >>>> diff --git a/src/test/feature/.gitignore b/src/test/feature/.gitignore
> >>>> index a2e6bd4..c7332b2 100644
> >>>> --- a/src/test/feature/.gitignore
> >>>> +++ b/src/test/feature/.gitignore
> >>>> @@ -1 +1,2 @@
> >>>> doc/
> >>>> +**/*.out
> >>>>
> >>>> diff --git a/src/test/feature/Makefile b/src/test/feature/Makefile
> >>>> index adc6acc..e0985d1 100644
> >>>> --- a/src/test/feature/Makefile
> >>>> +++ b/src/test/feature/Makefile
> >>>> @@ -35,6 +35,7 @@ doc:
> >>>> doxygen doxygen_template
> >>>>
> >>>> clean distclean: sharelibclean
> >>>> + find . -type f -name "*.out" |xargs rm -f
> >>>> $(RM) feature-test
> >>>> $(RM) feature-test.dSYM
> >>
> >>
> >>
> >> --
> >> Best Regards,
> >> Xiang Sheng
> >>
>
Re: About *.out files in test/feature
Posted by Paul Guo <pa...@gmail.com>.
Note "make installcheck-good" output files (directory results) could be
removed in "make clean" or "make distclean" also.
2016-07-12 13:35 GMT+08:00 Paul Guo <pa...@gmail.com>:
> Although gnu distclean means below, but the explananation is incomplete.
> Things
>
> could be more complex than simple configuration & build. Besides,
>
> We are not GNU programs so we do not have to 100% follow the GNU
> convention.
>
> The key point is that we need a target to make repo clean.
>
>
> <https://www.gnu.org/prep/standards/html_node/Standard-Targets.html>
> https://www.gnu.org/prep/standards/html_node/Standard-Targets.html
> ‘distclean’
> <https://www.gnu.org/prep/standards/html_node/Standard-Targets.html>
> <https://www.gnu.org/prep/standards/html_node/Standard-Targets.html>
>
> Delete all files in the current directory (or created by this makefile)
> that are created by configuring or building the program. If you have
> unpacked the source and built the program without creating any other files,
> ‘make distclean’ should leave only the files that were in the
> distribution. However, there is no need to delete parent directories that
> were created with ‘mkdir -p’, since they could have existed anyway.
>
>
>
>
> 2016-07-12 11:57 GMT+08:00 Gmail <xu...@gmail.com>:
>
>> I agree with ruilong.
>> Make clean should clean files generated only in make process.
>>
>> Make distclean should clean files generated in make and configure process.
>>
>> xunzhang
>> Send from my iPhone
>>
>>
>>
>> 发自我的 iPhone
>> > 在 2016年7月12日，11:40，Ruilong Huo <rh...@pivotal.io> 写道：
>> >
>> > I think "make clean" should only clean the files generated during
>> compile
>> > process.
>> > The *.out files are created by feature test code with psql, so I would
>> > prefer keep them.
>> > If you would like to clean them, that should be in feature test
>> framework,
>> > not in makefile.
>> >
>> > Any comments?
>> >
>> > Best regards,
>> > Ruilong Huo
>> >
>> >> On Tue, Jul 12, 2016 at 11:37 AM, Xiang Sheng <xs...@pivotal.io>
>> wrote:
>> >>
>> >> We indeed should delete these useless files after runing make clean or
>> make
>> >> distclean.
>> >>
>> >>> On Tue, Jul 12, 2016 at 11:35 AM, Ming Li <ml...@pivotal.io> wrote:
>> >>>
>> >>> LGTM. +1.
>> >>>
>> >>>> On Tue, Jul 12, 2016 at 11:32 AM, Paul Guo <pa...@gmail.com>
>> wrote:
>> >>>>
>> >>>> I'd mask the output files after running feature tests in .gitignore
>> and
>> >>>> clean it up after running "make clean" or "make distclean". Anyone
>> has
>> >>> any
>> >>>> suggestions? Thanks.
>> >>>>
>> >>>> diff --git a/src/test/feature/.gitignore
>> b/src/test/feature/.gitignore
>> >>>> index a2e6bd4..c7332b2 100644
>> >>>> --- a/src/test/feature/.gitignore
>> >>>> +++ b/src/test/feature/.gitignore
>> >>>> @@ -1 +1,2 @@
>> >>>> doc/
>> >>>> +**/*.out
>> >>>>
>> >>>> diff --git a/src/test/feature/Makefile b/src/test/feature/Makefile
>> >>>> index adc6acc..e0985d1 100644
>> >>>> --- a/src/test/feature/Makefile
>> >>>> +++ b/src/test/feature/Makefile
>> >>>> @@ -35,6 +35,7 @@ doc:
>> >>>> doxygen doxygen_template
>> >>>>
>> >>>> clean distclean: sharelibclean
>> >>>> + find . -type f -name "*.out" |xargs rm -f
>> >>>> $(RM) feature-test
>> >>>> $(RM) feature-test.dSYM
>> >>
>> >>
>> >>
>> >> --
>> >> Best Regards,
>> >> Xiang Sheng
>> >>
>>
>
>
Re: About *.out files in test/feature
Posted by Paul Guo <pa...@gmail.com>.
Although gnu distclean means below, but the explananation is incomplete.
Things
could be more complex than simple configuration & build. Besides,
We are not GNU programs so we do not have to 100% follow the GNU convention.
The key point is that we need a target to make repo clean.
<https://www.gnu.org/prep/standards/html_node/Standard-Targets.html>
https://www.gnu.org/prep/standards/html_node/Standard-Targets.html
‘distclean’
<https://www.gnu.org/prep/standards/html_node/Standard-Targets.html>
<https://www.gnu.org/prep/standards/html_node/Standard-Targets.html>
Delete all files in the current directory (or created by this makefile)
that are created by configuring or building the program. If you have
unpacked the source and built the program without creating any other files,
‘make distclean’ should leave only the files that were in the distribution.
However, there is no need to delete parent directories that were created
with ‘mkdir -p’, since they could have existed anyway.
2016-07-12 11:57 GMT+08:00 Gmail <xu...@gmail.com>:
> I agree with ruilong.
> Make clean should clean files generated only in make process.
>
> Make distclean should clean files generated in make and configure process.
>
> xunzhang
> Send from my iPhone
>
>
>
> 发自我的 iPhone
> > 在 2016年7月12日，11:40，Ruilong Huo <rh...@pivotal.io> 写道：
> >
> > I think "make clean" should only clean the files generated during compile
> > process.
> > The *.out files are created by feature test code with psql, so I would
> > prefer keep them.
> > If you would like to clean them, that should be in feature test
> framework,
> > not in makefile.
> >
> > Any comments?
> >
> > Best regards,
> > Ruilong Huo
> >
> >> On Tue, Jul 12, 2016 at 11:37 AM, Xiang Sheng <xs...@pivotal.io>
> wrote:
> >>
> >> We indeed should delete these useless files after runing make clean or
> make
> >> distclean.
> >>
> >>> On Tue, Jul 12, 2016 at 11:35 AM, Ming Li <ml...@pivotal.io> wrote:
> >>>
> >>> LGTM. +1.
> >>>
> >>>> On Tue, Jul 12, 2016 at 11:32 AM, Paul Guo <pa...@gmail.com> wrote:
> >>>>
> >>>> I'd mask the output files after running feature tests in .gitignore
> and
> >>>> clean it up after running "make clean" or "make distclean". Anyone has
> >>> any
> >>>> suggestions? Thanks.
> >>>>
> >>>> diff --git a/src/test/feature/.gitignore b/src/test/feature/.gitignore
> >>>> index a2e6bd4..c7332b2 100644
> >>>> --- a/src/test/feature/.gitignore
> >>>> +++ b/src/test/feature/.gitignore
> >>>> @@ -1 +1,2 @@
> >>>> doc/
> >>>> +**/*.out
> >>>>
> >>>> diff --git a/src/test/feature/Makefile b/src/test/feature/Makefile
> >>>> index adc6acc..e0985d1 100644
> >>>> --- a/src/test/feature/Makefile
> >>>> +++ b/src/test/feature/Makefile
> >>>> @@ -35,6 +35,7 @@ doc:
> >>>> doxygen doxygen_template
> >>>>
> >>>> clean distclean: sharelibclean
> >>>> + find . -type f -name "*.out" |xargs rm -f
> >>>> $(RM) feature-test
> >>>> $(RM) feature-test.dSYM
> >>
> >>
> >>
> >> --
> >> Best Regards,
> >> Xiang Sheng
> >>
>
Re: About *.out files in test/feature
Posted by Gmail <xu...@gmail.com>.
I agree with ruilong.
Make clean should clean files generated only in make process.
Make distclean should clean files generated in make and configure process.
xunzhang
Send from my iPhone
发自我的 iPhone
> 在 2016年7月12日，11:40，Ruilong Huo <rh...@pivotal.io> 写道：
>
> I think "make clean" should only clean the files generated during compile
> process.
> The *.out files are created by feature test code with psql, so I would
> prefer keep them.
> If you would like to clean them, that should be in feature test framework,
> not in makefile.
>
> Any comments?
>
> Best regards,
> Ruilong Huo
>
>> On Tue, Jul 12, 2016 at 11:37 AM, Xiang Sheng <xs...@pivotal.io> wrote:
>>
>> We indeed should delete these useless files after runing make clean or make
>> distclean.
>>
>>> On Tue, Jul 12, 2016 at 11:35 AM, Ming Li <ml...@pivotal.io> wrote:
>>>
>>> LGTM. +1.
>>>
>>>> On Tue, Jul 12, 2016 at 11:32 AM, Paul Guo <pa...@gmail.com> wrote:
>>>>
>>>> I'd mask the output files after running feature tests in .gitignore and
>>>> clean it up after running "make clean" or "make distclean". Anyone has
>>> any
>>>> suggestions? Thanks.
>>>>
>>>> diff --git a/src/test/feature/.gitignore b/src/test/feature/.gitignore
>>>> index a2e6bd4..c7332b2 100644
>>>> --- a/src/test/feature/.gitignore
>>>> +++ b/src/test/feature/.gitignore
>>>> @@ -1 +1,2 @@
>>>> doc/
>>>> +**/*.out
>>>>
>>>> diff --git a/src/test/feature/Makefile b/src/test/feature/Makefile
>>>> index adc6acc..e0985d1 100644
>>>> --- a/src/test/feature/Makefile
>>>> +++ b/src/test/feature/Makefile
>>>> @@ -35,6 +35,7 @@ doc:
>>>> doxygen doxygen_template
>>>>
>>>> clean distclean: sharelibclean
>>>> + find . -type f -name "*.out" |xargs rm -f
>>>> $(RM) feature-test
>>>> $(RM) feature-test.dSYM
>>
>>
>>
>> --
>> Best Regards,
>> Xiang Sheng
>>
Re: About *.out files in test/feature
Posted by Ruilong Huo <rh...@pivotal.io>.
I think "make clean" should only clean the files generated during compile
process.
The *.out files are created by feature test code with psql, so I would
prefer keep them.
If you would like to clean them, that should be in feature test framework,
not in makefile.
Any comments?
Best regards,
Ruilong Huo
On Tue, Jul 12, 2016 at 11:37 AM, Xiang Sheng <xs...@pivotal.io> wrote:
> We indeed should delete these useless files after runing make clean or make
> distclean.
>
> On Tue, Jul 12, 2016 at 11:35 AM, Ming Li <ml...@pivotal.io> wrote:
>
> > LGTM. +1.
> >
> > On Tue, Jul 12, 2016 at 11:32 AM, Paul Guo <pa...@gmail.com> wrote:
> >
> > > I'd mask the output files after running feature tests in .gitignore and
> > > clean it up after running "make clean" or "make distclean". Anyone has
> > any
> > > suggestions? Thanks.
> > >
> > > diff --git a/src/test/feature/.gitignore b/src/test/feature/.gitignore
> > > index a2e6bd4..c7332b2 100644
> > > --- a/src/test/feature/.gitignore
> > > +++ b/src/test/feature/.gitignore
> > > @@ -1 +1,2 @@
> > > doc/
> > > +**/*.out
> > >
> > > diff --git a/src/test/feature/Makefile b/src/test/feature/Makefile
> > > index adc6acc..e0985d1 100644
> > > --- a/src/test/feature/Makefile
> > > +++ b/src/test/feature/Makefile
> > > @@ -35,6 +35,7 @@ doc:
> > > doxygen doxygen_template
> > >
> > > clean distclean: sharelibclean
> > > + find . -type f -name "*.out" |xargs rm -f
> > > $(RM) feature-test
> > > $(RM) feature-test.dSYM
> > >
> >
>
>
>
> --
> Best Regards,
> Xiang Sheng
>
Re: About *.out files in test/feature
Posted by Xiang Sheng <xs...@pivotal.io>.
We indeed should delete these useless files after runing make clean or make
distclean.
On Tue, Jul 12, 2016 at 11:35 AM, Ming Li <ml...@pivotal.io> wrote:
> LGTM. +1.
>
> On Tue, Jul 12, 2016 at 11:32 AM, Paul Guo <pa...@gmail.com> wrote:
>
> > I'd mask the output files after running feature tests in .gitignore and
> > clean it up after running "make clean" or "make distclean". Anyone has
> any
> > suggestions? Thanks.
> >
> > diff --git a/src/test/feature/.gitignore b/src/test/feature/.gitignore
> > index a2e6bd4..c7332b2 100644
> > --- a/src/test/feature/.gitignore
> > +++ b/src/test/feature/.gitignore
> > @@ -1 +1,2 @@
> > doc/
> > +**/*.out
> >
> > diff --git a/src/test/feature/Makefile b/src/test/feature/Makefile
> > index adc6acc..e0985d1 100644
> > --- a/src/test/feature/Makefile
> > +++ b/src/test/feature/Makefile
> > @@ -35,6 +35,7 @@ doc:
> > doxygen doxygen_template
> >
> > clean distclean: sharelibclean
> > + find . -type f -name "*.out" |xargs rm -f
> > $(RM) feature-test
> > $(RM) feature-test.dSYM
> >
>
--
Best Regards,
Xiang Sheng
Re: About *.out files in test/feature
Posted by Ivan Weng <iw...@pivotal.io>.
Good improvement. +1.
Regards,
Ivan
On Tue, Jul 12, 2016 at 11:35 AM, Ming Li <ml...@pivotal.io> wrote:
> LGTM. +1.
>
> On Tue, Jul 12, 2016 at 11:32 AM, Paul Guo <pa...@gmail.com> wrote:
>
> > I'd mask the output files after running feature tests in .gitignore and
> > clean it up after running "make clean" or "make distclean". Anyone has
> any
> > suggestions? Thanks.
> >
> > diff --git a/src/test/feature/.gitignore b/src/test/feature/.gitignore
> > index a2e6bd4..c7332b2 100644
> > --- a/src/test/feature/.gitignore
> > +++ b/src/test/feature/.gitignore
> > @@ -1 +1,2 @@
> > doc/
> > +**/*.out
> >
> > diff --git a/src/test/feature/Makefile b/src/test/feature/Makefile
> > index adc6acc..e0985d1 100644
> > --- a/src/test/feature/Makefile
> > +++ b/src/test/feature/Makefile
> > @@ -35,6 +35,7 @@ doc:
> > doxygen doxygen_template
> >
> > clean distclean: sharelibclean
> > + find . -type f -name "*.out" |xargs rm -f
> > $(RM) feature-test
> > $(RM) feature-test.dSYM
> >
>
Re: About *.out files in test/feature
Posted by Ming Li <ml...@pivotal.io>.
LGTM. +1.
On Tue, Jul 12, 2016 at 11:32 AM, Paul Guo <pa...@gmail.com> wrote:
> I'd mask the output files after running feature tests in .gitignore and
> clean it up after running "make clean" or "make distclean". Anyone has any
> suggestions? Thanks.
>
> diff --git a/src/test/feature/.gitignore b/src/test/feature/.gitignore
> index a2e6bd4..c7332b2 100644
> --- a/src/test/feature/.gitignore
> +++ b/src/test/feature/.gitignore
> @@ -1 +1,2 @@
> doc/
> +**/*.out
>
> diff --git a/src/test/feature/Makefile b/src/test/feature/Makefile
> index adc6acc..e0985d1 100644
> --- a/src/test/feature/Makefile
> +++ b/src/test/feature/Makefile
> @@ -35,6 +35,7 @@ doc:
> doxygen doxygen_template
>
> clean distclean: sharelibclean
> + find . -type f -name "*.out" |xargs rm -f
> $(RM) feature-test
> $(RM) feature-test.dSYM
>
Re: About *.out files in test/feature
Posted by Paul Guo <pa...@gmail.com>.
Filed JIRA: HAWQ-942 - Need to .gitignore and make-clean some test files
which are generated after running feature/test
<https://issues.apache.org/jira/browse/HAWQ-942>
If you have more concerns, you can move to JIRA. Closing this thread.
Thanks.
2016-07-12 13:52 GMT+08:00 Paul Guo <pa...@gmail.com>:
> I think we should remove them in "make distclean/clean" and .gitigore them
> also.
>
> ExternalSource/ans/exttab1.ans
> ExternalSource/sql/exttab1.sql
> UDF/ans/function_creation.ans
> UDF/sql/function_creation.sql
> feature-test
> testlib/ans/template.ans
> testlib/sql/template.sql
>
> By the way, if we remove all .out files in "make distclean/clean", that
> means in the
> future we should leave .out as a protected file suffix. i.e. Files should
> be with .out suffix
> **iff** they are output results after running sql scripts.
>
>
> 2016-07-12 13:40 GMT+08:00 Ming Li <ml...@pivotal.io>:
>
>> BTW, is there any pre-processed file with extension .source which will be
>> converted to sql file for testing?
>> Should we also consider these auto-generated sql files?
>> If so, maybe we should move these intermediate files to a temp dir, so
>> that
>> we can distinguish them from normal sql files.
>>
>> On Tue, Jul 12, 2016 at 1:18 PM, Paul Guo <pa...@gmail.com> wrote:
>>
>> > I would leave .diff file at least unmasked so that people could quickly
>> > find what cases failed.
>> >
>> > 2016-07-12 11:38 GMT+08:00 陶征霖 <zt...@apache.org>:
>> >
>> > > Besides .out, there also exists .diff, binary which should be ignored.
>> > >
>> > > 2016-07-12 11:32 GMT+08:00 Paul Guo <pa...@gmail.com>:
>> > >
>> > > > I'd mask the output files after running feature tests in .gitignore
>> and
>> > > > clean it up after running "make clean" or "make distclean". Anyone
>> has
>> > > any
>> > > > suggestions? Thanks.
>> > > >
>> > > > diff --git a/src/test/feature/.gitignore
>> b/src/test/feature/.gitignore
>> > > > index a2e6bd4..c7332b2 100644
>> > > > --- a/src/test/feature/.gitignore
>> > > > +++ b/src/test/feature/.gitignore
>> > > > @@ -1 +1,2 @@
>> > > > doc/
>> > > > +**/*.out
>> > > >
>> > > > diff --git a/src/test/feature/Makefile b/src/test/feature/Makefile
>> > > > index adc6acc..e0985d1 100644
>> > > > --- a/src/test/feature/Makefile
>> > > > +++ b/src/test/feature/Makefile
>> > > > @@ -35,6 +35,7 @@ doc:
>> > > > doxygen doxygen_template
>> > > >
>> > > > clean distclean: sharelibclean
>> > > > + find . -type f -name "*.out" |xargs rm -f
>> > > > $(RM) feature-test
>> > > > $(RM) feature-test.dSYM
>> > > >
>> > >
>> >
>>
>
>
Re: About *.out files in test/feature
Posted by Paul Guo <pa...@gmail.com>.
I think we should remove them in "make distclean/clean" and .gitigore them
also.
ExternalSource/ans/exttab1.ans
ExternalSource/sql/exttab1.sql
UDF/ans/function_creation.ans
UDF/sql/function_creation.sql
feature-test
testlib/ans/template.ans
testlib/sql/template.sql
By the way, if we remove all .out files in "make distclean/clean", that
means in the
future we should leave .out as a protected file suffix. i.e. Files should
be with .out suffix
**iff** they are output results after running sql scripts.
2016-07-12 13:40 GMT+08:00 Ming Li <ml...@pivotal.io>:
> BTW, is there any pre-processed file with extension .source which will be
> converted to sql file for testing?
> Should we also consider these auto-generated sql files?
> If so, maybe we should move these intermediate files to a temp dir, so that
> we can distinguish them from normal sql files.
>
> On Tue, Jul 12, 2016 at 1:18 PM, Paul Guo <pa...@gmail.com> wrote:
>
> > I would leave .diff file at least unmasked so that people could quickly
> > find what cases failed.
> >
> > 2016-07-12 11:38 GMT+08:00 陶征霖 <zt...@apache.org>:
> >
> > > Besides .out, there also exists .diff, binary which should be ignored.
> > >
> > > 2016-07-12 11:32 GMT+08:00 Paul Guo <pa...@gmail.com>:
> > >
> > > > I'd mask the output files after running feature tests in .gitignore
> and
> > > > clean it up after running "make clean" or "make distclean". Anyone
> has
> > > any
> > > > suggestions? Thanks.
> > > >
> > > > diff --git a/src/test/feature/.gitignore
> b/src/test/feature/.gitignore
> > > > index a2e6bd4..c7332b2 100644
> > > > --- a/src/test/feature/.gitignore
> > > > +++ b/src/test/feature/.gitignore
> > > > @@ -1 +1,2 @@
> > > > doc/
> > > > +**/*.out
> > > >
> > > > diff --git a/src/test/feature/Makefile b/src/test/feature/Makefile
> > > > index adc6acc..e0985d1 100644
> > > > --- a/src/test/feature/Makefile
> > > > +++ b/src/test/feature/Makefile
> > > > @@ -35,6 +35,7 @@ doc:
> > > > doxygen doxygen_template
> > > >
> > > > clean distclean: sharelibclean
> > > > + find . -type f -name "*.out" |xargs rm -f
> > > > $(RM) feature-test
> > > > $(RM) feature-test.dSYM
> > > >
> > >
> >
>
Re: About *.out files in test/feature
Posted by Ming Li <ml...@pivotal.io>.
BTW, is there any pre-processed file with extension .source which will be
converted to sql file for testing?
Should we also consider these auto-generated sql files?
If so, maybe we should move these intermediate files to a temp dir, so that
we can distinguish them from normal sql files.
On Tue, Jul 12, 2016 at 1:18 PM, Paul Guo <pa...@gmail.com> wrote:
> I would leave .diff file at least unmasked so that people could quickly
> find what cases failed.
>
> 2016-07-12 11:38 GMT+08:00 陶征霖 <zt...@apache.org>:
>
> > Besides .out, there also exists .diff, binary which should be ignored.
> >
> > 2016-07-12 11:32 GMT+08:00 Paul Guo <pa...@gmail.com>:
> >
> > > I'd mask the output files after running feature tests in .gitignore and
> > > clean it up after running "make clean" or "make distclean". Anyone has
> > any
> > > suggestions? Thanks.
> > >
> > > diff --git a/src/test/feature/.gitignore b/src/test/feature/.gitignore
> > > index a2e6bd4..c7332b2 100644
> > > --- a/src/test/feature/.gitignore
> > > +++ b/src/test/feature/.gitignore
> > > @@ -1 +1,2 @@
> > > doc/
> > > +**/*.out
> > >
> > > diff --git a/src/test/feature/Makefile b/src/test/feature/Makefile
> > > index adc6acc..e0985d1 100644
> > > --- a/src/test/feature/Makefile
> > > +++ b/src/test/feature/Makefile
> > > @@ -35,6 +35,7 @@ doc:
> > > doxygen doxygen_template
> > >
> > > clean distclean: sharelibclean
> > > + find . -type f -name "*.out" |xargs rm -f
> > > $(RM) feature-test
> > > $(RM) feature-test.dSYM
> > >
> >
>
Re: About *.out files in test/feature
Posted by Paul Guo <pa...@gmail.com>.
I would leave .diff file at least unmasked so that people could quickly
find what cases failed.
2016-07-12 11:38 GMT+08:00 陶征霖 <zt...@apache.org>:
> Besides .out, there also exists .diff, binary which should be ignored.
>
> 2016-07-12 11:32 GMT+08:00 Paul Guo <pa...@gmail.com>:
>
> > I'd mask the output files after running feature tests in .gitignore and
> > clean it up after running "make clean" or "make distclean". Anyone has
> any
> > suggestions? Thanks.
> >
> > diff --git a/src/test/feature/.gitignore b/src/test/feature/.gitignore
> > index a2e6bd4..c7332b2 100644
> > --- a/src/test/feature/.gitignore
> > +++ b/src/test/feature/.gitignore
> > @@ -1 +1,2 @@
> > doc/
> > +**/*.out
> >
> > diff --git a/src/test/feature/Makefile b/src/test/feature/Makefile
> > index adc6acc..e0985d1 100644
> > --- a/src/test/feature/Makefile
> > +++ b/src/test/feature/Makefile
> > @@ -35,6 +35,7 @@ doc:
> > doxygen doxygen_template
> >
> > clean distclean: sharelibclean
> > + find . -type f -name "*.out" |xargs rm -f
> > $(RM) feature-test
> > $(RM) feature-test.dSYM
> >
>
Re: About *.out files in test/feature
Posted by 陶征霖 <zt...@apache.org>.
Besides .out, there also exists .diff, binary which should be ignored.
2016-07-12 11:32 GMT+08:00 Paul Guo <pa...@gmail.com>:
> I'd mask the output files after running feature tests in .gitignore and
> clean it up after running "make clean" or "make distclean". Anyone has any
> suggestions? Thanks.
>
> diff --git a/src/test/feature/.gitignore b/src/test/feature/.gitignore
> index a2e6bd4..c7332b2 100644
> --- a/src/test/feature/.gitignore
> +++ b/src/test/feature/.gitignore
> @@ -1 +1,2 @@
> doc/
> +**/*.out
>
> diff --git a/src/test/feature/Makefile b/src/test/feature/Makefile
> index adc6acc..e0985d1 100644
> --- a/src/test/feature/Makefile
> +++ b/src/test/feature/Makefile
> @@ -35,6 +35,7 @@ doc:
> doxygen doxygen_template
>
> clean distclean: sharelibclean
> + find . -type f -name "*.out" |xargs rm -f
> $(RM) feature-test
> $(RM) feature-test.dSYM
>