You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "irvifa (via GitHub)" <gi...@apache.org> on 2023/06/26 10:55:59 UTC
[GitHub] [airflow] irvifa opened a new pull request, #32144: fix: Fix GCS to BigQuery Operator
irvifa opened a new pull request, #32144:
URL: https://github.com/apache/airflow/pull/32144
We have different definition for both of the project where we run the job, destination project, and hook project. We shouldn't hardcode the value of the runner project id into the destination project id.
related: https://github.com/apache/airflow/issues/32093
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal closed pull request #32144: fix: Fix GCS to BigQuery Operator
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal closed pull request #32144: fix: Fix GCS to BigQuery Operator
URL: https://github.com/apache/airflow/pull/32144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #32144: fix: Fix GCS to BigQuery Operator
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #32144:
URL: https://github.com/apache/airflow/pull/32144#issuecomment-1623060063
Closed in favor of https://github.com/apache/airflow/pull/32232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] irvifa commented on pull request #32144: fix: Fix GCS to BigQuery Operator
Posted by "irvifa (via GitHub)" <gi...@apache.org>.
irvifa commented on PR #32144:
URL: https://github.com/apache/airflow/pull/32144#issuecomment-1608817710
@hussein-awala don't we need to fallback to the hook project id if the project id is not set though?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hussein-awala commented on pull request #32144: fix: Fix GCS to BigQuery Operator
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on PR #32144:
URL: https://github.com/apache/airflow/pull/32144#issuecomment-1607533607
There is an open PR (#32095) to fix the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org