[GitHub] [pinot] amrishlal commented on pull request #9669: [Work In Progress] Avoid setting result column types to STRING when resultset is empty.

[GitBox <gi...@apache.org>]

amrishlal commented on PR #9669:
URL: https://github.com/apache/pinot/pull/9669#issuecomment-1298876212

   @Jackie-Jiang @siddharthteotia Things are now setup so that a query will always run against at least one segment and this will allow for properly setting result metadata column names and types. I am not seeing a case where `ResultsBlockUtils.buildEmptyQueryResults` will be called anymore, so this function could potentially be removed if we are ok with query running against at least one segment on the server side.
   
   The change is not backward compatible only if we assume that a client is relying on the earlier incorrect behavior of returning all column types as STRING when resultset is empty otherwise for a large majority of clients we should be good. Let me know what you think.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org