You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "taskain7 (via GitHub)" <gi...@apache.org> on 2024/03/12 01:19:05 UTC
[PR] FINERACT-2060: re-amortization [fineract]
taskain7 opened a new pull request, #3793:
URL: https://github.com/apache/fineract/pull/3793
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2060: re-amortization [fineract]
Posted by "taskain7 (via GitHub)" <gi...@apache.org>.
taskain7 commented on code in PR #3793:
URL: https://github.com/apache/fineract/pull/3793#discussion_r1522941612
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/ReAmortizationTest.java:
##########
@@ -0,0 +1,468 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.integrationtests;
+
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+
+import java.math.BigDecimal;
+import org.apache.fineract.client.models.GetLoanProductsProductIdResponse;
+import org.apache.fineract.client.models.PostLoanProductsRequest;
+import org.apache.fineract.client.models.PostLoanProductsResponse;
+import org.apache.fineract.integrationtests.common.ClientHelper;
+import org.apache.fineract.integrationtests.common.loans.LoanTestLifecycleExtension;
+import org.apache.fineract.portfolio.loanaccount.loanschedule.domain.LoanScheduleProcessingType;
+import org.apache.fineract.portfolio.loanaccount.loanschedule.domain.LoanScheduleType;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+
+@ExtendWith(LoanTestLifecycleExtension.class)
+public class ReAmortizationTest extends BaseLoanIntegrationTest {
Review Comment:
I moved my test there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2060: re-amortization [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #3793:
URL: https://github.com/apache/fineract/pull/3793#discussion_r1521172954
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -496,7 +532,15 @@ private void processSingleTransaction(LoanTransaction loanTransaction, MonetaryC
* For existing transactions, check if the re-payment breakup (principal, interest, fees, penalties) has
* changed.<br>
*/
- final LoanTransaction newLoanTransaction = LoanTransaction.copyTransactionProperties(loanTransaction);
+ LoanTransaction newLoanTransaction = LoanTransaction.copyTransactionProperties(loanTransaction);
+ LocalDate transactionDate = loanTransaction.getTransactionDate();
+ if (loanTransaction.getTypeOf().equals(REAMORTIZE)) {
Review Comment:
I dont think we need this.
I think the original logic should collect the outstanding principal amounts and check whether the new balance is matching with the original transaction amount or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2060: re-amortization [fineract]
Posted by "taskain7 (via GitHub)" <gi...@apache.org>.
taskain7 commented on code in PR #3793:
URL: https://github.com/apache/fineract/pull/3793#discussion_r1522940775
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -182,13 +185,46 @@ public void processLatestTransaction(LoanTransaction loanTransaction, Transactio
case CHARGE_PAYMENT -> handleChargePayment(loanTransaction, ctx.getCurrency(), ctx.getInstallments(), ctx.getCharges(),
ctx.getOverpaymentHolder());
case WAIVE_CHARGES -> log.debug("WAIVE_CHARGES transaction will not be processed.");
+ case REAMORTIZE -> handleReAmortization(loanTransaction, ctx.getCurrency(), ctx.getInstallments());
// TODO: Cover rest of the transaction types
default -> {
log.warn("Unhandled transaction processing for transaction type: {}", loanTransaction.getTypeOf());
}
}
}
+ private void handleReAmortization(LoanTransaction loanTransaction, MonetaryCurrency currency,
+ List<LoanRepaymentScheduleInstallment> installments) {
+ BigDecimal remainingAmount = loanTransaction.getAmount();
+ LocalDate transactionDate = loanTransaction.getTransactionDate();
+ List<LoanRepaymentScheduleInstallment> previousInstallments = installments.stream() //
+ .filter(installment -> !installment.getDueDate().isAfter(transactionDate)) //
+ .toList();
+ List<LoanRepaymentScheduleInstallment> futureInstallments = installments.stream() //
+ .filter(installment -> installment.getDueDate().isAfter(transactionDate)) //
+ .filter(installment -> !installment.isAdditional()) //
+ .toList();
+ previousInstallments.forEach(installment -> {
Review Comment:
fixed
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/InternalLoanInformationApiResource.java:
##########
@@ -48,10 +47,8 @@
import org.apache.fineract.portfolio.loanproduct.data.AdvancedPaymentData;
import org.apache.fineract.portfolio.loanproduct.mapper.AdvancedPaymentDataMapper;
import org.springframework.beans.factory.InitializingBean;
-import org.springframework.context.annotation.Profile;
import org.springframework.stereotype.Component;
-@Profile(FineractProfiles.TEST)
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2060: re-amortization [fineract]
Posted by "galovics (via GitHub)" <gi...@apache.org>.
galovics commented on code in PR #3793:
URL: https://github.com/apache/fineract/pull/3793#discussion_r1521279866
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/ReAmortizationTest.java:
##########
@@ -0,0 +1,468 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.integrationtests;
+
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+
+import java.math.BigDecimal;
+import org.apache.fineract.client.models.GetLoanProductsProductIdResponse;
+import org.apache.fineract.client.models.PostLoanProductsRequest;
+import org.apache.fineract.client.models.PostLoanProductsResponse;
+import org.apache.fineract.integrationtests.common.ClientHelper;
+import org.apache.fineract.integrationtests.common.loans.LoanTestLifecycleExtension;
+import org.apache.fineract.portfolio.loanaccount.loanschedule.domain.LoanScheduleProcessingType;
+import org.apache.fineract.portfolio.loanaccount.loanschedule.domain.LoanScheduleType;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+
+@ExtendWith(LoanTestLifecycleExtension.class)
+public class ReAmortizationTest extends BaseLoanIntegrationTest {
Review Comment:
There's an existing test for reamortization called LoanReAmortizationIntegrationTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2060: re-amortization [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #3793:
URL: https://github.com/apache/fineract/pull/3793#discussion_r1521149702
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -496,7 +532,15 @@ private void processSingleTransaction(LoanTransaction loanTransaction, MonetaryC
* For existing transactions, check if the re-payment breakup (principal, interest, fees, penalties) has
* changed.<br>
*/
- final LoanTransaction newLoanTransaction = LoanTransaction.copyTransactionProperties(loanTransaction);
+ LoanTransaction newLoanTransaction = LoanTransaction.copyTransactionProperties(loanTransaction);
Review Comment:
Why do we need this? This PR should not cover the "reverse-replay", no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2060: re-amortization [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #3793:
URL: https://github.com/apache/fineract/pull/3793#discussion_r1521170386
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -182,13 +185,46 @@ public void processLatestTransaction(LoanTransaction loanTransaction, Transactio
case CHARGE_PAYMENT -> handleChargePayment(loanTransaction, ctx.getCurrency(), ctx.getInstallments(), ctx.getCharges(),
ctx.getOverpaymentHolder());
case WAIVE_CHARGES -> log.debug("WAIVE_CHARGES transaction will not be processed.");
+ case REAMORTIZE -> handleReAmortization(loanTransaction, ctx.getCurrency(), ctx.getInstallments());
// TODO: Cover rest of the transaction types
default -> {
log.warn("Unhandled transaction processing for transaction type: {}", loanTransaction.getTypeOf());
}
}
}
+ private void handleReAmortization(LoanTransaction loanTransaction, MonetaryCurrency currency,
+ List<LoanRepaymentScheduleInstallment> installments) {
+ BigDecimal remainingAmount = loanTransaction.getAmount();
+ LocalDate transactionDate = loanTransaction.getTransactionDate();
+ List<LoanRepaymentScheduleInstallment> previousInstallments = installments.stream() //
+ .filter(installment -> !installment.getDueDate().isAfter(transactionDate)) //
+ .toList();
+ List<LoanRepaymentScheduleInstallment> futureInstallments = installments.stream() //
+ .filter(installment -> installment.getDueDate().isAfter(transactionDate)) //
+ .filter(installment -> !installment.isAdditional()) //
+ .toList();
+ previousInstallments.forEach(installment -> {
Review Comment:
I think what you need here is:
- collect the outstanding principal in a field
- Remove the outstanding principal from the installment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2060: re-amortization [fineract]
Posted by "taskain7 (via GitHub)" <gi...@apache.org>.
taskain7 commented on code in PR #3793:
URL: https://github.com/apache/fineract/pull/3793#discussion_r1522941303
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -496,7 +532,15 @@ private void processSingleTransaction(LoanTransaction loanTransaction, MonetaryC
* For existing transactions, check if the re-payment breakup (principal, interest, fees, penalties) has
* changed.<br>
*/
- final LoanTransaction newLoanTransaction = LoanTransaction.copyTransactionProperties(loanTransaction);
+ LoanTransaction newLoanTransaction = LoanTransaction.copyTransactionProperties(loanTransaction);
+ LocalDate transactionDate = loanTransaction.getTransactionDate();
+ if (loanTransaction.getTypeOf().equals(REAMORTIZE)) {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2060: re-amortization [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #3793:
URL: https://github.com/apache/fineract/pull/3793#discussion_r1521152045
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/reamortization/LoanReAmortizationServiceImpl.java:
##########
@@ -117,6 +131,23 @@ private void reverseReAmortizeTransaction(LoanTransaction reAmortizeTransaction,
LoanReAmortizationApiConstants.externalIdParameterName);
reAmortizeTransaction.reverse(reversalExternalId);
reAmortizeTransaction.manuallyAdjustedOrReversed();
+ reProcessLoanTransactions(reAmortizeTransaction.getLoan());
+ }
+
+ private void reProcessLoanTransactions(Loan loan) {
Review Comment:
Why do we need to reprocess the transactions? Reamortization is always the latest transaction, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2060: re-amortization [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #3793:
URL: https://github.com/apache/fineract/pull/3793#discussion_r1521149702
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -496,7 +532,15 @@ private void processSingleTransaction(LoanTransaction loanTransaction, MonetaryC
* For existing transactions, check if the re-payment breakup (principal, interest, fees, penalties) has
* changed.<br>
*/
- final LoanTransaction newLoanTransaction = LoanTransaction.copyTransactionProperties(loanTransaction);
+ LoanTransaction newLoanTransaction = LoanTransaction.copyTransactionProperties(loanTransaction);
Review Comment:
Why do we need this? This PR should not cover the "reverse-replay", no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2060: re-amortization [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #3793:
URL: https://github.com/apache/fineract/pull/3793#discussion_r1521152045
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/reamortization/LoanReAmortizationServiceImpl.java:
##########
@@ -117,6 +131,23 @@ private void reverseReAmortizeTransaction(LoanTransaction reAmortizeTransaction,
LoanReAmortizationApiConstants.externalIdParameterName);
reAmortizeTransaction.reverse(reversalExternalId);
reAmortizeTransaction.manuallyAdjustedOrReversed();
+ reProcessLoanTransactions(reAmortizeTransaction.getLoan());
+ }
+
+ private void reProcessLoanTransactions(Loan loan) {
Review Comment:
Why do we need to reprocess the transactions? Reamortization is always the latest transaction, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2060: re-amortization [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #3793:
URL: https://github.com/apache/fineract/pull/3793#discussion_r1521140485
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -182,13 +185,46 @@ public void processLatestTransaction(LoanTransaction loanTransaction, Transactio
case CHARGE_PAYMENT -> handleChargePayment(loanTransaction, ctx.getCurrency(), ctx.getInstallments(), ctx.getCharges(),
ctx.getOverpaymentHolder());
case WAIVE_CHARGES -> log.debug("WAIVE_CHARGES transaction will not be processed.");
+ case REAMORTIZE -> handleReAmortization(loanTransaction, ctx.getCurrency(), ctx.getInstallments());
// TODO: Cover rest of the transaction types
default -> {
log.warn("Unhandled transaction processing for transaction type: {}", loanTransaction.getTypeOf());
}
}
}
+ private void handleReAmortization(LoanTransaction loanTransaction, MonetaryCurrency currency,
+ List<LoanRepaymentScheduleInstallment> installments) {
+ BigDecimal remainingAmount = loanTransaction.getAmount();
+ LocalDate transactionDate = loanTransaction.getTransactionDate();
+ List<LoanRepaymentScheduleInstallment> previousInstallments = installments.stream() //
+ .filter(installment -> !installment.getDueDate().isAfter(transactionDate)) //
+ .toList();
+ List<LoanRepaymentScheduleInstallment> futureInstallments = installments.stream() //
+ .filter(installment -> installment.getDueDate().isAfter(transactionDate)) //
+ .filter(installment -> !installment.isAdditional()) //
+ .toList();
+ previousInstallments.forEach(installment -> {
Review Comment:
I dont really understand this logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2060: re-amortization [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #3793:
URL: https://github.com/apache/fineract/pull/3793#discussion_r1521140485
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -182,13 +185,46 @@ public void processLatestTransaction(LoanTransaction loanTransaction, Transactio
case CHARGE_PAYMENT -> handleChargePayment(loanTransaction, ctx.getCurrency(), ctx.getInstallments(), ctx.getCharges(),
ctx.getOverpaymentHolder());
case WAIVE_CHARGES -> log.debug("WAIVE_CHARGES transaction will not be processed.");
+ case REAMORTIZE -> handleReAmortization(loanTransaction, ctx.getCurrency(), ctx.getInstallments());
// TODO: Cover rest of the transaction types
default -> {
log.warn("Unhandled transaction processing for transaction type: {}", loanTransaction.getTypeOf());
}
}
}
+ private void handleReAmortization(LoanTransaction loanTransaction, MonetaryCurrency currency,
+ List<LoanRepaymentScheduleInstallment> installments) {
+ BigDecimal remainingAmount = loanTransaction.getAmount();
+ LocalDate transactionDate = loanTransaction.getTransactionDate();
+ List<LoanRepaymentScheduleInstallment> previousInstallments = installments.stream() //
+ .filter(installment -> !installment.getDueDate().isAfter(transactionDate)) //
+ .toList();
+ List<LoanRepaymentScheduleInstallment> futureInstallments = installments.stream() //
+ .filter(installment -> installment.getDueDate().isAfter(transactionDate)) //
+ .filter(installment -> !installment.isAdditional()) //
+ .toList();
+ previousInstallments.forEach(installment -> {
Review Comment:
are you sure about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2060: re-amortization [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #3793:
URL: https://github.com/apache/fineract/pull/3793#discussion_r1521150402
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/InternalLoanInformationApiResource.java:
##########
@@ -48,10 +47,8 @@
import org.apache.fineract.portfolio.loanproduct.data.AdvancedPaymentData;
import org.apache.fineract.portfolio.loanproduct.mapper.AdvancedPaymentDataMapper;
import org.springframework.beans.factory.InitializingBean;
-import org.springframework.context.annotation.Profile;
import org.springframework.stereotype.Component;
-@Profile(FineractProfiles.TEST)
Review Comment:
Please undo this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2060: re-amortization [fineract]
Posted by "taskain7 (via GitHub)" <gi...@apache.org>.
taskain7 merged PR #3793:
URL: https://github.com/apache/fineract/pull/3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org