[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6043: Add IN_PARTITIONED_SUBQUERY support

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on pull request #6043:
URL: https://github.com/apache/incubator-pinot/pull/6043#issuecomment-708000083


   > Looking at the implementation, the subquery can take only predicate which is translated to a filter. Then we might not want `IN_PARTITIONED_SUBQUERY ` to take a free-formed SQL query as the argument.
   > 
   > The signature can be :
   > 
   > ```
   > IN_PARTITIONED_SUBQUERY (col, col_filtrerTable, filterTable, conditions_filterTable)
   > ```
   
   @yupeng9 Added some validation on the subquery. I prefer having the sql query as the argument because that is more flexible, and we can add other subquery support easier in the future.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org