You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/07/21 00:55:49 UTC

[GitHub] [iceberg] rdblue commented on a change in pull request #1214: [Python] Minor fixes for tests

rdblue commented on a change in pull request #1214:
URL: https://github.com/apache/iceberg/pull/1214#discussion_r457773039



##########
File path: python/iceberg/api/partition_spec.py
##########
@@ -183,7 +183,7 @@ def __repr__(self):
         return "".join(sb)
 
     @staticmethod
-    def builder_for(schema):
+    def builder_for(schema: Schema) -> "PartitionSpecBuilder":

Review comment:
       Why is `PartitionSpecBuilder` in quotes?
   
   Not a problem, I've just not seen that before. `Schema` isn't in quotes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org