You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Kouhei Sutou (Jira)" <ji...@apache.org> on 2022/09/24 20:17:00 UTC

[jira] [Resolved] (ARROW-17823) [C++] Prefer std::make_shared/std::make_unique over constructor with new

     [ https://issues.apache.org/jira/browse/ARROW-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kouhei Sutou resolved ARROW-17823.
----------------------------------
    Resolution: Fixed

Issue resolved by pull request 14216
[https://github.com/apache/arrow/pull/14216]

> [C++] Prefer std::make_shared/std::make_unique over constructor with new
> ------------------------------------------------------------------------
>
>                 Key: ARROW-17823
>                 URL: https://issues.apache.org/jira/browse/ARROW-17823
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>    Affects Versions: 9.0.0
>            Reporter: Jin Shang
>            Assignee: Jin Shang
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 10.0.0
>
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> Advantage: readabilty, exception safety and efficiency(only for shared_ptr).
> Cases that don't apply: When calling a private/protected constructor within class member function, make_shared/unique can't work.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)