You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/05/28 20:44:59 UTC

[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2340: Enable/Disable Messaging in Read Only instance mode

josehernandezfintecheandomx opened a new pull request, #2340:
URL: https://github.com/apache/fineract/pull/2340

   ## Description
   
   When a Fineract instance is running as read-only, all event receiving/sending shall be disabled
   
   In case of a read-only instance, the best way to prevent events from being sent and received is to simply disable the messaging configuration (JMS/etc), that way there’s not even a connection established for the brokers.
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
   
   - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
   
   - [ ] Create/update unit or integration tests for verifying the changes made.
   
   - [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)
   
   FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] galovics merged pull request #2340: Enable/Disable Messaging in Read Only instance mode

Posted by GitBox <gi...@apache.org>.
galovics merged PR #2340:
URL: https://github.com/apache/fineract/pull/2340


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] galovics commented on a diff in pull request #2340: Enable/Disable Messaging in Read Only instance mode

Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2340:
URL: https://github.com/apache/fineract/pull/2340#discussion_r885296735


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/config/EnableFineractEventsCondition.java:
##########
@@ -0,0 +1,40 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.infrastructure.core.config;
+
+import java.util.Optional;
+import lombok.RequiredArgsConstructor;
+import org.springframework.context.annotation.Condition;
+import org.springframework.context.annotation.ConditionContext;
+import org.springframework.core.type.AnnotatedTypeMetadata;
+
+@RequiredArgsConstructor
+public class EnableFineractEventsCondition implements Condition {

Review Comment:
   Nice job. I don't think we need the `@RequiredArgsConstructor` because we don't have any fields.
   
   Also, since this is now a programmatic condition, we can introduce *unit* tests to cover the behavior. Please add it and then we're good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] galovics commented on a diff in pull request #2340: Enable/Disable Messaging in Read Only instance mode

Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2340:
URL: https://github.com/apache/fineract/pull/2340#discussion_r884658074


##########
fineract-provider/src/main/java/org/apache/fineract/notification/config/MessagingConfiguration.java:
##########
@@ -35,6 +36,7 @@
 
 @Configuration
 @Profile("activeMqEnabled")
+@ConditionalOnExpression("${fineract.mode.write-enabled:true} || ${fineract.mode.batch-enabled:true}")

Review Comment:
   I wish we could use programmatic conditions here with the FineractModeProperties POJO.
   
   Before merging, please look at this: https://stackoverflow.com/a/69901997/2863995
   And let's try to make it work.
   
   @taskain7 already created a programmatic Condition here: `FineractModeValidationCondition`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2340: Enable/Disable Messaging in Read Only instance mode

Posted by GitBox <gi...@apache.org>.
josehernandezfintecheandomx commented on code in PR #2340:
URL: https://github.com/apache/fineract/pull/2340#discussion_r885526302


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/config/EnableFineractEventsCondition.java:
##########
@@ -0,0 +1,40 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.infrastructure.core.config;
+
+import java.util.Optional;
+import lombok.RequiredArgsConstructor;
+import org.springframework.context.annotation.Condition;
+import org.springframework.context.annotation.ConditionContext;
+import org.springframework.core.type.AnnotatedTypeMetadata;
+
+@RequiredArgsConstructor
+public class EnableFineractEventsCondition implements Condition {

Review Comment:
   The annotation has been removed, which kind of UT we can create? Remember If we don't have write mode in the UT we have not database



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2340: Enable/Disable Messaging in Read Only instance mode

Posted by GitBox <gi...@apache.org>.
josehernandezfintecheandomx commented on code in PR #2340:
URL: https://github.com/apache/fineract/pull/2340#discussion_r885110702


##########
fineract-provider/src/main/java/org/apache/fineract/notification/config/MessagingConfiguration.java:
##########
@@ -35,6 +36,7 @@
 
 @Configuration
 @Profile("activeMqEnabled")
+@ConditionalOnExpression("${fineract.mode.write-enabled:true} || ${fineract.mode.batch-enabled:true}")

Review Comment:
   Done! Condition created: `EnableFineractEventsCondition` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org