You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/01/06 01:24:41 UTC

[GitHub] [incubator-apisix-dashboard] lilien1010 commented on a change in pull request #110: fix apache apisix icon not show issue

lilien1010 commented on a change in pull request #110: fix apache apisix icon not show issue
URL: https://github.com/apache/incubator-apisix-dashboard/pull/110#discussion_r363132755
 
 

 ##########
 File path: src/layout/components/Sidebar/SidebarLogo.vue
 ##########
 @@ -69,6 +69,29 @@ export default class extends Vue {
   @Prop({ required: true }) private collapse!: boolean
 
   private title = 'APISIX'
+
+  get getIco() {
 
 Review comment:
   sure thisPR is too complicated, but I think use the same link from link.rel will keep the Icon link consistent

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services