[GitHub] [lucene] gsmiller commented on a diff in pull request #11832: Added static factory method for loading VectorValues

[GitBox <gi...@apache.org>]

gsmiller commented on code in PR #11832:
URL: https://github.com/apache/lucene/pull/11832#discussion_r984025608


##########
lucene/core/src/java/org/apache/lucene/index/CheckIndex.java:
##########
@@ -2585,7 +2585,7 @@ public static Status.VectorValuesStatus testVectors(
                       + "\" has vector values but dimension is "
                       + dimension);
             }
-            VectorValues values = reader.getVectorValues(fieldInfo.name);
+            VectorValues values = VectorValues.getVectorValues(reader, fieldInfo.name);
             if (values == null) {

Review Comment:
   We shouldn't need to check `values == null` here anymore right since `VectorValues#getVectorValues` never returns null?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org