[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #588: Add sequential number prepare for supporting row level delete (WIP)

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #588: Add sequential number prepare for supporting row level delete (WIP)
URL: https://github.com/apache/incubator-iceberg/pull/588#discussion_r344834993
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/DataFile.java
 ##########
 @@ -152,4 +153,16 @@ static StructType getType(StructType partitionType) {
    * are determined by these offsets. The returned list must be sorted in ascending order.
    */
   List<Long> splitOffsets();
+
+  /**
+   * @return sequential number of this data file if exists, null otherwise.
+   */
+  Long seqNum();
+
+  /**
+   * Assign a sequential number to data file.
+   *
+   * @param seqNum the sequential number to assign
+   */
+  void setSeqNum(long seqNum);
 
 Review comment:
   This interface should not include a setter method. `DataFile` is effectively immutable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org