You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/06/23 17:56:13 UTC
[GitHub] [samza] DPUkyle opened a new pull request #1391: SAMZA-2555: Prevent downloading checkstyle DTD over the internet
DPUkyle opened a new pull request #1391:
URL: https://github.com/apache/samza/pull/1391
- By using exact DTD definitions, checkstyle tool will locate resources from within its own jar, avoiding download.
- Using exact values from checkstyle 6.11.2 release, see:
- configuration: https://github.com/checkstyle/checkstyle/blob/checkstyle-6.11.2/src/main/resources/com/puppycrawl/tools/checkstyle/configuration_1_3.dtd#L6
- suppressions: https://github.com/checkstyle/checkstyle/blob/checkstyle-6.11.2/src/main/resources/com/puppycrawl/tools/checkstyle/suppressions_1_1.dtd#L6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] cameronlee314 merged pull request #1391: SAMZA-2555: Prevent downloading checkstyle DTD over the internet
Posted by GitBox <gi...@apache.org>.
cameronlee314 merged pull request #1391:
URL: https://github.com/apache/samza/pull/1391
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] alnzng commented on pull request #1391: SAMZA-2555: Prevent downloading checkstyle DTD over the internet
Posted by GitBox <gi...@apache.org>.
alnzng commented on pull request #1391:
URL: https://github.com/apache/samza/pull/1391#issuecomment-648335147
LGTM, thanks @DPUkyle
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org