You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/08/04 18:02:00 UTC
[jira] [Work logged] (GOBBLIN-1222) Create right abstraction to
assemble dataset staging dir for Hive dataset finder
[ https://issues.apache.org/jira/browse/GOBBLIN-1222?focusedWorklogId=466365&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-466365 ]
ASF GitHub Bot logged work on GOBBLIN-1222:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Aug/20 18:01
Start Date: 04/Aug/20 18:01
Worklog Time Spent: 10m
Work Description: autumnust commented on a change in pull request #3070:
URL: https://github.com/apache/incubator-gobblin/pull/3070#discussion_r465231243
##########
File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/hive/HiveDataset.java
##########
@@ -94,6 +96,7 @@
// Will not be serialized/de-serialized
protected transient final Properties properties;
+ public Properties getProperties() { return properties; }
Review comment:
Please move the method into the section below (methods should stay with method. Also you can use lombok annotation for boilerplate code. Check the "@Getter" annotation in the codebase for example)
##########
File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/writer/FileAwareInputStreamDataWriter.java
##########
@@ -139,17 +141,22 @@ public FileAwareInputStreamDataWriter(State state, int numBranches, int branchId
URI uri = URI.create(uriStr);
this.fs = FileSystem.get(uri, conf);
this.fileContext = FileContext.getFileContext(uri, conf);
+ this.copyableDatasetMetadata =
+ CopyableDatasetMetadata.deserialize(state.getProp(CopySource.SERIALIZED_COPYABLE_DATASET));
if (state.getPropAsBoolean(ConfigurationKeys.USER_DEFINED_STAGING_DIR_FLAG,false)) {
this.stagingDir = new Path(state.getProp(ConfigurationKeys.USER_DEFINED_STATIC_STAGING_DIR));
+ } else if ((state.getPropAsBoolean(ConfigurationKeys.DATASET_STAGING_DIR,false))) {
Review comment:
Can you add comments on this code block ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 466365)
Time Spent: 20m (was: 10m)
> Create right abstraction to assemble dataset staging dir for Hive dataset finder
> --------------------------------------------------------------------------------
>
> Key: GOBBLIN-1222
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1222
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Vaibhav Arya
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)