[GitHub] [ozone] jojochuang commented on a diff in pull request #3637: HDDS-6775. Add more performance logs to DataNode disk/container operations

[GitBox <gi...@apache.org>]

jojochuang commented on code in PR #3637:
URL: https://github.com/apache/ozone/pull/3637#discussion_r943979699


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java:
##########
@@ -304,10 +313,25 @@ private ContainerCommandResponseProto dispatchRequest(
       audit(action, eventType, params, AuditEventStatus.FAILURE, ex);
       return ContainerUtils.logAndReturnError(LOG, ex, msg);
     }
+    long handlingStartTime = Time.monotonicNow();
     responseProto = handler.handle(msg, container, dispatcherContext);
     if (responseProto != null) {
+      long requestDurationMs = Time.monotonicNow() - startTime;
+      long handlingDurationMs = Time.monotonicNow() - handlingStartTime;

Review Comment:
   There's already metric for the handler.
   The warning is for something is really really off and shouldn't flood the log file.
   My experience is that most people don't set up alerts (because they didn't even know where to look at), and it becomes hard to look at in a retrospective. Having a log warning when things is really bad allows quick troubleshooting.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org