You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2015/08/25 19:57:45 UTC
[jira] [Commented] (SOLR-7967)
AddSchemaFieldsUpdateProcessorFactory does not check if the ConfigSet is
immutable
[ https://issues.apache.org/jira/browse/SOLR-7967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711686#comment-14711686 ]
Hoss Man commented on SOLR-7967:
--------------------------------
bq. ...so if you view the ConfigSet in totality you could argue nothing is really changing. I'd slightly lean towards adding the check, but could go either way.
I'm not all that familiar with how Immutable ConfigSets work internally, or what the "designed" usecase / usage patterns are, but i think the right questions to ask are:
* what _might_ users reasonably want to do to in conjunction with (Immutable) ConfigSets and a data driven schema?
* what, logically, should be the default behavior of (Immutable) ConfigSets and a data driven schema?
The answer(s) to the first question should all be _possible_ even if they require special configuration -- and or: if some conbinations of options XYZ give you errors telling you that the combination is invalid and needs to be changed to either XQZ or XYP to make sense and be usable.
The answer to the second question should be the default behavior, w/o any special config.
> AddSchemaFieldsUpdateProcessorFactory does not check if the ConfigSet is immutable
> ----------------------------------------------------------------------------------
>
> Key: SOLR-7967
> URL: https://issues.apache.org/jira/browse/SOLR-7967
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Affects Versions: 5.3, Trunk
> Reporter: Gregory Chanan
>
> SOLR-7742 introduced Immutable ConfigSets. There are checks added to SolrConfigHandler and SchemaHandler so that if a user tries to modify the SolrConfig or the Schema via either of these interfaces an error is returned if the ConfigSet is defined to be immutable.
> Updates to the schema made via the AddSchemaFieldsUpdateProcessorFactory are not checked in this way. I'm not certain this should be considered a bug. A ConfigSet is defined by \{SolrConfig, Schema, ConfigSetProperties\}. On one hand, you can argue that you are modifying the Schema, which is part of the ConfigSet, so the immutable check should apply. On the other hand, the SolrConfig (which defines the AddSchema...Factory} defines that it wants the Config to be updated, so if you view the ConfigSet in totality you could argue nothing is really changing. I'd slightly lean towards adding the check, but could go either way.
> Other opinions?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org