You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "iloveeyjafjalla (via GitHub)" <gi...@apache.org> on 2026/10/18 11:47:35 UTC
[PR] fix(alerts): stop calling a failed runtime read "not collected" [rocketmq-dashboard]
iloveeyjafjalla opened a new pull request, #6941:
URL: https://github.com/apache/rocketmq-dashboard/pull/6941
Fixes #6940
## The defect
`listAlertRuleRuntime(...).catch(() => undefined)` discarded the failure, and the runtime column renders 未采集 for any rule without a runtime row — so a failed read asserted that every rule's collection is off, and a failed refresh left stale firing/pending states in place.
## The fix
The failure is state: the previous values are dropped (they describe a different read), the column renders `-` with `alerts.runtimeLoadFailed` as its title/aria-label, and a successful empty read keeps the honest 未采集.
## Tests
Red before the change (`未采集` present after a rejected runtime read), green after with the whole page suite:
```
Tests 38 passed (38) (AlertsPage.test.tsx)
tsc -b exit 0
eslint exit 0 (five pre-existing warnings in alerts.tsx)
prettier --check All matched files use Prettier code style!
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(alerts): stop calling a failed runtime read "not collected" [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6941:
URL: https://github.com/apache/rocketmq-dashboard/pull/6941#issuecomment-6405400742
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(alerts): stop calling a failed runtime read "not collected" [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #6941: fix(alerts): stop calling a failed runtime read "not collected"
URL: https://github.com/apache/rocketmq-dashboard/pull/6941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org