[GitHub] [hudi] vinothchandar commented on a change in pull request #3267: [HUDI-2170] Always choose the latest record for HoodieRecordPayload

[GitBox <gi...@apache.org>]

vinothchandar commented on a change in pull request #3267:
URL: https://github.com/apache/hudi/pull/3267#discussion_r681298546



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/model/OverwriteWithLatestAvroPayload.java
##########
@@ -25,8 +25,12 @@
 import org.apache.avro.generic.GenericRecord;
 import org.apache.avro.generic.IndexedRecord;
 
+import javax.annotation.Nullable;

Review comment:
       deal with this across the board? instead of just for this class. 
   

##########
File path: hudi-common/src/main/java/org/apache/hudi/common/model/DefaultHoodieRecordPayload.java
##########
@@ -43,6 +43,10 @@
   public static final String METADATA_EVENT_TIME_KEY = "metadata.event_time.key";
   private Option<Object> eventTime = Option.empty();
 
+  public DefaultHoodieRecordPayload(GenericRecord record, String orderingField) {

Review comment:
       can this be not passed in the properties sent to the payload? Love to not introduce a new constructor, if we don't have to




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org