You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Andrew Stitcher <as...@apache.org> on 2014/06/03 19:13:18 UTC
Review Request 22212: Some more space saving changes for Proton-C
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22212/
-----------------------------------------------------------
Review request for qpid, Kenneth Giusti and Rafael Schloming.
Bugs: PROTON-516, PROTON-590 and PROTON-591
https://issues.apache.org/jira/browse/PROTON-516
https://issues.apache.org/jira/browse/PROTON-590
https://issues.apache.org/jira/browse/PROTON-591
Repository: qpid
Description
-------
More changes to save dynamic memory use:
(These changes should save 4k per connection on a regular 64 bit system installation of proton-c).
This is the sum of fixes for PROTON-516, PROTON-591 (and PROTON-590 which is fixed by the change for PROTON-591).
There are some other small clean ups too (include paths and removing unused #defines)
Diffs
-----
/proton/trunk/examples/CMakeLists.txt 1598389
/proton/trunk/proton-c/CMakeLists.txt 1598389
/proton/trunk/proton-c/src/dispatch_actions.h PRE-CREATION
/proton/trunk/proton-c/src/dispatcher/dispatcher.h 1598389
/proton/trunk/proton-c/src/dispatcher/dispatcher.c 1598389
/proton/trunk/proton-c/src/engine/engine-internal.h 1598389
/proton/trunk/proton-c/src/sasl/sasl.c 1598389
/proton/trunk/proton-c/src/transport/transport.c 1598389
/proton/trunk/tests/tools/apps/c/CMakeLists.txt 1598389
Diff: https://reviews.apache.org/r/22212/diff/
Testing
-------
ctest
Thanks,
Andrew Stitcher
Re: Review Request 22212: Some more space saving changes for Proton-C
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22212/#review44654
-----------------------------------------------------------
Ship it!
Ship It!
- Kenneth Giusti
On June 3, 2014, 5:13 p.m., Andrew Stitcher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22212/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 5:13 p.m.)
>
>
> Review request for qpid, Kenneth Giusti and Rafael Schloming.
>
>
> Bugs: PROTON-516, PROTON-590 and PROTON-591
> https://issues.apache.org/jira/browse/PROTON-516
> https://issues.apache.org/jira/browse/PROTON-590
> https://issues.apache.org/jira/browse/PROTON-591
>
>
> Repository: qpid
>
>
> Description
> -------
>
> More changes to save dynamic memory use:
> (These changes should save 4k per connection on a regular 64 bit system installation of proton-c).
>
> This is the sum of fixes for PROTON-516, PROTON-591 (and PROTON-590 which is fixed by the change for PROTON-591).
>
> There are some other small clean ups too (include paths and removing unused #defines)
>
>
> Diffs
> -----
>
> /proton/trunk/examples/CMakeLists.txt 1598389
> /proton/trunk/proton-c/CMakeLists.txt 1598389
> /proton/trunk/proton-c/src/dispatch_actions.h PRE-CREATION
> /proton/trunk/proton-c/src/dispatcher/dispatcher.h 1598389
> /proton/trunk/proton-c/src/dispatcher/dispatcher.c 1598389
> /proton/trunk/proton-c/src/engine/engine-internal.h 1598389
> /proton/trunk/proton-c/src/sasl/sasl.c 1598389
> /proton/trunk/proton-c/src/transport/transport.c 1598389
> /proton/trunk/tests/tools/apps/c/CMakeLists.txt 1598389
>
> Diff: https://reviews.apache.org/r/22212/diff/
>
>
> Testing
> -------
>
> ctest
>
>
> Thanks,
>
> Andrew Stitcher
>
>
Re: Review Request 22212: Some more space saving changes for Proton-C
Posted by Rafael Schloming <rh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22212/#review44645
-----------------------------------------------------------
Ship it!
Ship It!
- Rafael Schloming
On June 3, 2014, 5:13 p.m., Andrew Stitcher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22212/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 5:13 p.m.)
>
>
> Review request for qpid, Kenneth Giusti and Rafael Schloming.
>
>
> Bugs: PROTON-516, PROTON-590 and PROTON-591
> https://issues.apache.org/jira/browse/PROTON-516
> https://issues.apache.org/jira/browse/PROTON-590
> https://issues.apache.org/jira/browse/PROTON-591
>
>
> Repository: qpid
>
>
> Description
> -------
>
> More changes to save dynamic memory use:
> (These changes should save 4k per connection on a regular 64 bit system installation of proton-c).
>
> This is the sum of fixes for PROTON-516, PROTON-591 (and PROTON-590 which is fixed by the change for PROTON-591).
>
> There are some other small clean ups too (include paths and removing unused #defines)
>
>
> Diffs
> -----
>
> /proton/trunk/examples/CMakeLists.txt 1598389
> /proton/trunk/proton-c/CMakeLists.txt 1598389
> /proton/trunk/proton-c/src/dispatch_actions.h PRE-CREATION
> /proton/trunk/proton-c/src/dispatcher/dispatcher.h 1598389
> /proton/trunk/proton-c/src/dispatcher/dispatcher.c 1598389
> /proton/trunk/proton-c/src/engine/engine-internal.h 1598389
> /proton/trunk/proton-c/src/sasl/sasl.c 1598389
> /proton/trunk/proton-c/src/transport/transport.c 1598389
> /proton/trunk/tests/tools/apps/c/CMakeLists.txt 1598389
>
> Diff: https://reviews.apache.org/r/22212/diff/
>
>
> Testing
> -------
>
> ctest
>
>
> Thanks,
>
> Andrew Stitcher
>
>