[GitHub] janpio edited a comment on issue #507: ios build.json debug/release signing not working as i expected

[GitBox <gi...@apache.org>]

janpio edited a comment on issue #507: ios build.json debug/release signing not working as i expected
URL: https://github.com/apache/cordova-ios/issues/507#issuecomment-458118884
 
 
   Do the builds with `--release` and `--debug` work as expected?
   
   (What follows now is all speculation, I was not involved in the implementation of this feature and also did not check the actual code before writing this!)
   
   If so, that is probably all that was intended by this feature when it was created. The `build.json` file was probably introduced as an alternative way to supplying the certificate information via the command line - and there is probably also configures all the settings to the one supplied data.
   
   But, of course you are not wrong that it could be nice to have a "better" configured Xcode project. Someone would have to take a look at the code to see if this can be refactored to work that way, and check especially was happens when only one of both are supplied via `build.json`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org