You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Alioth4J (via GitHub)" <gi...@apache.org> on 2025/12/03 08:41:02 UTC
[PR] Fix multiple SLF4J providers [maven]
Alioth4J opened a new pull request, #11516:
URL: https://github.com/apache/maven/pull/11516
Closes #11515.
## Description
`MavenServiceProvider` and `LogbackServiceProvider` are found.
In this project, only the API of logback is used, so the logback dependency could be removed and the code in `LogbackConfiguration` could be refactored with reflection.
## Changes
1. Remove logback dependency in `pom.xml`, `impl/maven-cli/pom.xml`, `compat/maven-embedder/pom.xml`.
2. Remove `<logbackClassicVersion>` in `pom.xml`.
3. Refactor `LogbackConfiguration.java` using reflection.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in other changes.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line and body.
Note that commits might be squashed by a maintainer on merge.
- [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [ ] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix multiple SLF4J providers [maven]
Posted by "Alioth4J (via GitHub)" <gi...@apache.org>.
Alioth4J closed pull request #11516: Fix multiple SLF4J providers
URL: https://github.com/apache/maven/pull/11516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix multiple SLF4J providers [maven]
Posted by "Alioth4J (via GitHub)" <gi...@apache.org>.
Alioth4J commented on PR #11516:
URL: https://github.com/apache/maven/pull/11516#issuecomment-3616867911
Hi @elharo,
I think you are right. Using reflection does introduce a lot of problems. I'm closing this PR.
Thank you very much for the review and feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org