[GitHub] [spark] erenavsarogullari commented on pull request #28865: [SPARK-32026][CORE] Support consistency on Prometheus driver and executor metrics format

[GitBox <gi...@apache.org>]

erenavsarogullari commented on pull request #28865:
URL: https://github.com/apache/spark/pull/28865#issuecomment-648561686


   Hi @dongjoon-hyun, 
   
   Thanks for the review and details.
   
   Prometheus format seems following JMX-Exporter and also introducing type attribute(e.g: type="gauges"). I think we would like to continue preserving the same format, right?
   
   On the other hand, what about Unit Tests for `PrometheusServlet` in the light of this PR coverage? I think they can still be useful.
   
   **Jmx:**
   ```
   metrics_local_1592959391297_driver_BlockManager_memory_memUsed_MB_Value{instance="172.16.0.122:8088",job="mysparkapp"} 0
   ```
   
   **Prometheus:**
   ```
   metrics_local_1592960380968_driver_BlockManager_memory_memUsed_MB_Value{instance="172.16.0.122:4041",job="spark-driver",type="gauges"} 0
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org