You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2024/12/16 17:22:21 UTC
(superset) branch master updated: fix(filter options): full size list item targets (#31449)
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 48510d2ffb fix(filter options): full size list item targets (#31449)
48510d2ffb is described below
commit 48510d2ffbc29b1fbe502535e2232eeb3ab302d4
Author: Evan Rusackas <ev...@preset.io>
AuthorDate: Mon Dec 16 10:22:14 2024 -0700
fix(filter options): full size list item targets (#31449)
---
.../src/components/DropdownSelectableIcon/index.tsx | 7 ++++---
.../nativeFilters/FilterBar/FilterConfigurationLink/index.tsx | 10 +++++++---
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/superset-frontend/src/components/DropdownSelectableIcon/index.tsx b/superset-frontend/src/components/DropdownSelectableIcon/index.tsx
index a1b755dcf2..12d23dc242 100644
--- a/superset-frontend/src/components/DropdownSelectableIcon/index.tsx
+++ b/superset-frontend/src/components/DropdownSelectableIcon/index.tsx
@@ -90,8 +90,9 @@ const StyleMenuItem = styled(Menu.Item)<{ divider?: boolean }>`
const StyleSubmenuItem = styled.div`
display: flex;
justify-content: space-between;
- > span {
- width: 100%;
+ width: 100%;
+ > div {
+ flex-grow: 1;
}
`;
@@ -102,7 +103,7 @@ export default (props: DropDownSelectableProps) => {
() => (label: string | ReactNode, key: string, divider?: boolean) => (
<StyleMenuItem key={key} divider={divider}>
<StyleSubmenuItem>
- <span>{label}</span>
+ {label}
{selectedKeys?.includes(key) && (
<Icons.Check
iconColor={theme.colors.primary.base}
diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterConfigurationLink/index.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterConfigurationLink/index.tsx
index f8164d241a..6b4fea62a4 100644
--- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterConfigurationLink/index.tsx
+++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterConfigurationLink/index.tsx
@@ -62,10 +62,14 @@ export const FilterConfigurationLink: FC<FCBProps> = ({
return (
<>
- {/* eslint-disable-next-line jsx-a11y/no-static-element-interactions */}
- <span {...getFilterBarTestId('create-filter')} onClick={handleClick}>
+ <div
+ {...getFilterBarTestId('create-filter')}
+ onClick={handleClick}
+ role="button"
+ tabIndex={0}
+ >
{children}
- </span>
+ </div>
<FiltersConfigModal
isOpen={isOpen}
onSave={submit}