You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2009/04/02 15:12:13 UTC

[jira] Commented: (HADOOP-5613) change S3Exception to checked exception

    [ https://issues.apache.org/jira/browse/HADOOP-5613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694999#action_12694999 ] 

Hadoop QA commented on HADOOP-5613:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12404421/patch-ioexceptions.patch
  against trunk revision 761082.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/99/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/99/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/99/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/99/console

This message is automatically generated.

> change S3Exception to checked exception
> ---------------------------------------
>
>                 Key: HADOOP-5613
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5613
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: fs/s3
>    Affects Versions: 0.18.3
>            Reporter: Andrew Hitchcock
>            Priority: Minor
>         Attachments: patch-ioexceptions.patch
>
>
> Currently the S3 filesystems can throw unchecked exceptions (S3Exception) which are not declared in the interface of FileSystem. These aren't caught by the various callers and can cause unpredictable behavior. IOExceptions are caught by most users of FileSystem since it is declared in the interface and hence is handled better.
> I propose we modify S3Exception to extend IOException.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.