You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by alsorokin <gi...@git.apache.org> on 2015/02/02 11:34:08 UTC

[GitHub] cordova-plugin-globalization pull request: CB-8394 - included wind...

GitHub user alsorokin opened a pull request:

    https://github.com/apache/cordova-plugin-globalization/pull/35

    CB-8394 - included windows and wp8 quirks into tests

    This is a fix for https://issues.apache.org/jira/browse/CB-8394
    
    The idea is to split failing tests into two parts (two `it`s):
    First part checks the functionality that is supported on all platforms,
    Second part checks the functionality that is unsupported on wp8 and windows and is marked pending on these two platforms.
    
    This way we can mark tests pending and still check the functionality that is supported.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-globalization windows-test-fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-globalization/pull/35.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #35
    
----
commit 82091b4354517dfc7366b2864af32d6681ba366f
Author: alsorokin <al...@akvelon.com>
Date:   2015-02-02T10:27:12Z

    CB-8394 - included windows and wp8 quirks into tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-globalization pull request: CB-8394 - included wind...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-globalization/pull/35


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org