You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/23 11:03:32 UTC

[GitHub] [airflow] turbaszek commented on pull request #20119: Remove cursor methods calls from GCSToBigQueryOperator

turbaszek commented on pull request #20119:
URL: https://github.com/apache/airflow/pull/20119#issuecomment-1048667485


   > We need someplace for complex dict creation, like configuration for bq_hook.insert_job() or table_recource for bq_hook.create_empty_table(). In my opinion, better to keep this code in BigQueryHook and don't move to Operator.
   
   Those dicts should be created by users. If we create them then we tend to miss some input arguments. Also in my opinion one input which is well described by Google docs is better than 20 arguments with copy pasted descriptions. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org