[jira] Resolved: (SHINDIG-496) PHP handler for canonical json db

["Chris Chabot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SHINDIG-496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Chabot resolved SHINDIG-496.
----------------------------------

    Resolution: Fixed
      Assignee: Chris Chabot

Applied & committed, thanks for the patch!

A few issues i ran into while integrating this patch:
- The patch didn't include proper file paths for the file names, so took a bit of hand work to apply :)
- there was no error checking to see if the json encoding actually worked or not
- by extend of above, if decoding failed, the new db was still written away (with empty data), so things would remain broken until you remove the temp json db file
- no error checking on reading & writing to files, never assume it will 'just work' :)
- getAll{People,Data,Activities} read in the db, and save it right away again ... why? No data was modified..
- getAll{People,Data,Activities} load in the data from file every time, while there's also $this->all{People,Data,Activities} available.. why not only load the data once and then use the internal var's? saves some execution time
- In the container.php you did specify the JsonDb service for the messages service, but didn't implement the MessagesService & it's createMessage function (so would lead to an exceptions when createMessage was called instead of a nice clean 'not supported' error)
- un-used private $converter var, and an empty __construct function
- for the test case you did modify the index.php file, but forgot about the AllTests.php file (the command line version of the same)
 


> PHP handler for canonical json db
> ---------------------------------
>
>                 Key: SHINDIG-496
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-496
>             Project: Shindig
>          Issue Type: New Feature
>          Components: Gadget Rendering Server (PHP)
>            Reporter: Gonzalo Aune
>            Assignee: Chris Chabot
>         Attachments: SHINDIG-496.patch
>
>
> The PHP side doesnt use the canonical json db, the handlers and services must be defined.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.