You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Kan Zhang (JIRA)" <ji...@apache.org> on 2009/05/13 23:54:45 UTC
[jira] Created: (HADOOP-5824) remove OP_READ_METADATA functionality
from Datanode
remove OP_READ_METADATA functionality from Datanode
---------------------------------------------------
Key: HADOOP-5824
URL: https://issues.apache.org/jira/browse/HADOOP-5824
Project: Hadoop Core
Issue Type: Bug
Reporter: Kan Zhang
Operation OP_READ_METADATA exists on the datanode streaming interface. But it is not used by any client code and is currently not protected by access token. Should it be removed?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5824) remove OP_READ_METADATA
functionality from Datanode
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709377#action_12709377 ]
Hadoop QA commented on HADOOP-5824:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12408086/5824-2.patch
against trunk revision 774625.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/337/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/337/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/337/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/337/console
This message is automatically generated.
> remove OP_READ_METADATA functionality from Datanode
> ---------------------------------------------------
>
> Key: HADOOP-5824
> URL: https://issues.apache.org/jira/browse/HADOOP-5824
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Attachments: 5824-0.patch, 5824-1.patch, 5824-2.patch
>
>
> Operation OP_READ_METADATA exists on the datanode streaming interface. But it is not used by any client code and is currently not protected by access token. Should it be removed?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5824) remove OP_READ_METADATA
functionality from Datanode
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709239#action_12709239 ]
Kan Zhang commented on HADOOP-5824:
-----------------------------------
> Should we also remove OP_READ_METADATA from DataTransferProtocol?
Added a new patch that deprecates the variable for now.
> remove OP_READ_METADATA functionality from Datanode
> ---------------------------------------------------
>
> Key: HADOOP-5824
> URL: https://issues.apache.org/jira/browse/HADOOP-5824
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Kan Zhang
> Attachments: 5824-0.patch, 5824-1.patch, 5824-2.patch
>
>
> Operation OP_READ_METADATA exists on the datanode streaming interface. But it is not used by any client code and is currently not protected by access token. Should it be removed?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5824) remove OP_READ_METADATA functionality
from Datanode
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kan Zhang updated HADOOP-5824:
------------------------------
Status: Patch Available (was: Open)
> remove OP_READ_METADATA functionality from Datanode
> ---------------------------------------------------
>
> Key: HADOOP-5824
> URL: https://issues.apache.org/jira/browse/HADOOP-5824
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Kan Zhang
> Attachments: 5824-0.patch
>
>
> Operation OP_READ_METADATA exists on the datanode streaming interface. But it is not used by any client code and is currently not protected by access token. Should it be removed?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5824) remove OP_READ_METADATA functionality
from Datanode
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5824:
-------------------------------------------
Resolution: Fixed
Fix Version/s: 0.21.0
Status: Resolved (was: Patch Available)
The failed tests are not related.
I have committed this. Thanks, Kan!
> remove OP_READ_METADATA functionality from Datanode
> ---------------------------------------------------
>
> Key: HADOOP-5824
> URL: https://issues.apache.org/jira/browse/HADOOP-5824
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Fix For: 0.21.0
>
> Attachments: 5824-0.patch, 5824-1.patch, 5824-2.patch
>
>
> Operation OP_READ_METADATA exists on the datanode streaming interface. But it is not used by any client code and is currently not protected by access token. Should it be removed?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5824) remove OP_READ_METADATA functionality
from Datanode
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kan Zhang updated HADOOP-5824:
------------------------------
Attachment: 5824-2.patch
> remove OP_READ_METADATA functionality from Datanode
> ---------------------------------------------------
>
> Key: HADOOP-5824
> URL: https://issues.apache.org/jira/browse/HADOOP-5824
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Kan Zhang
> Attachments: 5824-0.patch, 5824-1.patch, 5824-2.patch
>
>
> Operation OP_READ_METADATA exists on the datanode streaming interface. But it is not used by any client code and is currently not protected by access token. Should it be removed?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5824) remove OP_READ_METADATA
functionality from Datanode
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709157#action_12709157 ]
Raghu Angadi commented on HADOOP-5824:
--------------------------------------
+1 for removing it if it is not used.
> remove OP_READ_METADATA functionality from Datanode
> ---------------------------------------------------
>
> Key: HADOOP-5824
> URL: https://issues.apache.org/jira/browse/HADOOP-5824
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Kan Zhang
> Attachments: 5824-0.patch
>
>
> Operation OP_READ_METADATA exists on the datanode streaming interface. But it is not used by any client code and is currently not protected by access token. Should it be removed?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5824) remove OP_READ_METADATA functionality
from Datanode
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5824:
-------------------------------------------
Assignee: Kan Zhang
Hadoop Flags: [Reviewed]
+1 patch looks good.
> remove OP_READ_METADATA functionality from Datanode
> ---------------------------------------------------
>
> Key: HADOOP-5824
> URL: https://issues.apache.org/jira/browse/HADOOP-5824
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Attachments: 5824-0.patch, 5824-1.patch, 5824-2.patch
>
>
> Operation OP_READ_METADATA exists on the datanode streaming interface. But it is not used by any client code and is currently not protected by access token. Should it be removed?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5824) remove OP_READ_METADATA functionality
from Datanode
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kan Zhang updated HADOOP-5824:
------------------------------
Component/s: dfs
> remove OP_READ_METADATA functionality from Datanode
> ---------------------------------------------------
>
> Key: HADOOP-5824
> URL: https://issues.apache.org/jira/browse/HADOOP-5824
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Kan Zhang
> Attachments: 5824-0.patch
>
>
> Operation OP_READ_METADATA exists on the datanode streaming interface. But it is not used by any client code and is currently not protected by access token. Should it be removed?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5824) remove OP_READ_METADATA
functionality from Datanode
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709203#action_12709203 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-5824:
------------------------------------------------
I like this too. Should we also remove OP_READ_METADATA from DataTransferProtocol?
> remove OP_READ_METADATA functionality from Datanode
> ---------------------------------------------------
>
> Key: HADOOP-5824
> URL: https://issues.apache.org/jira/browse/HADOOP-5824
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Kan Zhang
> Attachments: 5824-0.patch
>
>
> Operation OP_READ_METADATA exists on the datanode streaming interface. But it is not used by any client code and is currently not protected by access token. Should it be removed?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5824) remove OP_READ_METADATA functionality
from Datanode
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kan Zhang updated HADOOP-5824:
------------------------------
Attachment: 5824-1.patch
> remove OP_READ_METADATA functionality from Datanode
> ---------------------------------------------------
>
> Key: HADOOP-5824
> URL: https://issues.apache.org/jira/browse/HADOOP-5824
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Kan Zhang
> Attachments: 5824-0.patch, 5824-1.patch
>
>
> Operation OP_READ_METADATA exists on the datanode streaming interface. But it is not used by any client code and is currently not protected by access token. Should it be removed?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5824) remove OP_READ_METADATA
functionality from Datanode
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709213#action_12709213 ]
Kan Zhang commented on HADOOP-5824:
-----------------------------------
> Should we also remove OP_READ_METADATA from DataTransferProtocol?
Yes, I attached a new patch to that effect. thanks.
> remove OP_READ_METADATA functionality from Datanode
> ---------------------------------------------------
>
> Key: HADOOP-5824
> URL: https://issues.apache.org/jira/browse/HADOOP-5824
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Kan Zhang
> Attachments: 5824-0.patch, 5824-1.patch
>
>
> Operation OP_READ_METADATA exists on the datanode streaming interface. But it is not used by any client code and is currently not protected by access token. Should it be removed?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5824) remove OP_READ_METADATA functionality
from Datanode
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kan Zhang updated HADOOP-5824:
------------------------------
Attachment: 5824-0.patch
> remove OP_READ_METADATA functionality from Datanode
> ---------------------------------------------------
>
> Key: HADOOP-5824
> URL: https://issues.apache.org/jira/browse/HADOOP-5824
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Kan Zhang
> Attachments: 5824-0.patch
>
>
> Operation OP_READ_METADATA exists on the datanode streaming interface. But it is not used by any client code and is currently not protected by access token. Should it be removed?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.