You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Prabhjyot Singh <pr...@gmail.com> on 2017/03/23 11:26:10 UTC
Review Request 57872: Interpreters that are not listed under
"zeppelin.interpreter.group.order" in zeppelin-site.xml should not get
installed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57872/
-----------------------------------------------------------
Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
Bugs: AMBARI-20539
https://issues.apache.org/jira/browse/AMBARI-20539
Repository: ambari
Description
-------
Interpreters that are not listed under "zeppelin.interpreter.group.order" in zeppelin-site.xml should not get installed and get configured.
Diffs
-----
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml 039c701
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py 38bfeb4
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py 0a0acdb
ambari-server/src/test/python/stacks/2.6/configs/default.json a1f89ce
Diff: https://reviews.apache.org/r/57872/diff/1/
Testing
-------
Manually on CentOS6
Thanks,
Prabhjyot Singh
Re: Review Request 57872: Interpreters that are not listed under
"zeppelin.interpreter.group.order" in zeppelin-site.xml should not get
installed
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57872/#review170133
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On March 25, 2017, 5:36 a.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57872/
> -----------------------------------------------------------
>
> (Updated March 25, 2017, 5:36 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20539
> https://issues.apache.org/jira/browse/AMBARI-20539
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Interpreters that are not listed under "zeppelin.interpreter.group.order" in zeppelin-site.xml should not get installed and get configured.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml 039c701
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py 575f7bc
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py 0a0acdb
> ambari-server/src/test/python/stacks/2.6/configs/default.json a1f89ce
>
>
> Diff: https://reviews.apache.org/r/57872/diff/3/
>
>
> Testing
> -------
>
> Manually on CentOS6
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 57872: Interpreters that are not listed under
"zeppelin.interpreter.group.order" in zeppelin-site.xml should not get
installed
Posted by Prabhjyot Singh <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57872/#review170076
-----------------------------------------------------------
@afernandez Since this is already merged into trunk, hence, openeing a new reivew request https://reviews.apache.org/r/57930/ for fixing the issues in this. Please ignore the uploaded diffs.
- Prabhjyot Singh
On March 25, 2017, 11:06 a.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57872/
> -----------------------------------------------------------
>
> (Updated March 25, 2017, 11:06 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20539
> https://issues.apache.org/jira/browse/AMBARI-20539
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Interpreters that are not listed under "zeppelin.interpreter.group.order" in zeppelin-site.xml should not get installed and get configured.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml 039c701
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py 575f7bc
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py 0a0acdb
> ambari-server/src/test/python/stacks/2.6/configs/default.json a1f89ce
>
>
> Diff: https://reviews.apache.org/r/57872/diff/3/
>
>
> Testing
> -------
>
> Manually on CentOS6
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 57872: Interpreters that are not listed under
"zeppelin.interpreter.group.order" in zeppelin-site.xml should not get
installed
Posted by Prabhjyot Singh <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57872/
-----------------------------------------------------------
(Updated March 25, 2017, 11:06 a.m.)
Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
Bugs: AMBARI-20539
https://issues.apache.org/jira/browse/AMBARI-20539
Repository: ambari
Description
-------
Interpreters that are not listed under "zeppelin.interpreter.group.order" in zeppelin-site.xml should not get installed and get configured.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml 039c701
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py 575f7bc
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py 0a0acdb
ambari-server/src/test/python/stacks/2.6/configs/default.json a1f89ce
Diff: https://reviews.apache.org/r/57872/diff/3/
Changes: https://reviews.apache.org/r/57872/diff/2-3/
Testing
-------
Manually on CentOS6
Thanks,
Prabhjyot Singh
Re: Review Request 57872: Interpreters that are not listed under
"zeppelin.interpreter.group.order" in zeppelin-site.xml should not get
installed
Posted by Prabhjyot Singh <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57872/
-----------------------------------------------------------
(Updated March 25, 2017, 11:04 a.m.)
Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
Bugs: AMBARI-20539
https://issues.apache.org/jira/browse/AMBARI-20539
Repository: ambari
Description
-------
Interpreters that are not listed under "zeppelin.interpreter.group.order" in zeppelin-site.xml should not get installed and get configured.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml 039c701
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py 575f7bc
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py 0a0acdb
ambari-server/src/test/python/stacks/2.6/configs/default.json a1f89ce
Diff: https://reviews.apache.org/r/57872/diff/2/
Changes: https://reviews.apache.org/r/57872/diff/1-2/
Testing
-------
Manually on CentOS6
Thanks,
Prabhjyot Singh
Re: Review Request 57872: Interpreters that are not listed under
"zeppelin.interpreter.group.order" in zeppelin-site.xml should not get
installed
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On March 24, 2017, 6:04 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
> > Lines 312 (patched)
> > <https://reviews.apache.org/r/57872/diff/1/?file=1672562#file1672562line312>
> >
> > do,
> > for settings_key,interpreter in interpreter_settings.itemitems():
>
> Alejandro Fernandez wrote:
> I meant iteritems()
>
> Prabhjyot Singh wrote:
> I was getting this error; Hence, using "for settings_key, interpreter in interpreter_settings.items():" please refer https://reviews.apache.org/r/57930/
>
> ```
> for settings_key, interpreter in interpreter_settings.itemitems():
> AttributeError: 'dict' object has no attribute 'itemitems'
> ```
iteritems()
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57872/#review170034
-----------------------------------------------------------
On March 25, 2017, 5:36 a.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57872/
> -----------------------------------------------------------
>
> (Updated March 25, 2017, 5:36 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20539
> https://issues.apache.org/jira/browse/AMBARI-20539
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Interpreters that are not listed under "zeppelin.interpreter.group.order" in zeppelin-site.xml should not get installed and get configured.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml 039c701
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py 575f7bc
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py 0a0acdb
> ambari-server/src/test/python/stacks/2.6/configs/default.json a1f89ce
>
>
> Diff: https://reviews.apache.org/r/57872/diff/3/
>
>
> Testing
> -------
>
> Manually on CentOS6
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 57872: Interpreters that are not listed under
"zeppelin.interpreter.group.order" in zeppelin-site.xml should not get
installed
Posted by Prabhjyot Singh <pr...@gmail.com>.
> On March 24, 2017, 11:34 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
> > Lines 314 (patched)
> > <https://reviews.apache.org/r/57872/diff/1/?file=1672562#file1672562line314>
> >
> > Can remove parentheses and do "not in "
Sure took care of it, please refer https://reviews.apache.org/r/57930/
- Prabhjyot
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57872/#review170034
-----------------------------------------------------------
On March 25, 2017, 11:06 a.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57872/
> -----------------------------------------------------------
>
> (Updated March 25, 2017, 11:06 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20539
> https://issues.apache.org/jira/browse/AMBARI-20539
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Interpreters that are not listed under "zeppelin.interpreter.group.order" in zeppelin-site.xml should not get installed and get configured.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml 039c701
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py 575f7bc
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py 0a0acdb
> ambari-server/src/test/python/stacks/2.6/configs/default.json a1f89ce
>
>
> Diff: https://reviews.apache.org/r/57872/diff/3/
>
>
> Testing
> -------
>
> Manually on CentOS6
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 57872: Interpreters that are not listed under
"zeppelin.interpreter.group.order" in zeppelin-site.xml should not get
installed
Posted by Prabhjyot Singh <pr...@gmail.com>.
> On March 24, 2017, 11:34 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
> > Lines 312 (patched)
> > <https://reviews.apache.org/r/57872/diff/1/?file=1672562#file1672562line312>
> >
> > do,
> > for settings_key,interpreter in interpreter_settings.itemitems():
>
> Alejandro Fernandez wrote:
> I meant iteritems()
I was getting this error; Hence, using "for settings_key, interpreter in interpreter_settings.items():" please refer https://reviews.apache.org/r/57930/
```
for settings_key, interpreter in interpreter_settings.itemitems():
AttributeError: 'dict' object has no attribute 'itemitems'
```
- Prabhjyot
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57872/#review170034
-----------------------------------------------------------
On March 25, 2017, 11:06 a.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57872/
> -----------------------------------------------------------
>
> (Updated March 25, 2017, 11:06 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20539
> https://issues.apache.org/jira/browse/AMBARI-20539
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Interpreters that are not listed under "zeppelin.interpreter.group.order" in zeppelin-site.xml should not get installed and get configured.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml 039c701
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py 575f7bc
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py 0a0acdb
> ambari-server/src/test/python/stacks/2.6/configs/default.json a1f89ce
>
>
> Diff: https://reviews.apache.org/r/57872/diff/3/
>
>
> Testing
> -------
>
> Manually on CentOS6
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 57872: Interpreters that are not listed under
"zeppelin.interpreter.group.order" in zeppelin-site.xml should not get
installed
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On March 24, 2017, 6:04 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
> > Lines 312 (patched)
> > <https://reviews.apache.org/r/57872/diff/1/?file=1672562#file1672562line312>
> >
> > do,
> > for settings_key,interpreter in interpreter_settings.itemitems():
I meant iteritems()
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57872/#review170034
-----------------------------------------------------------
On March 23, 2017, 11:26 a.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57872/
> -----------------------------------------------------------
>
> (Updated March 23, 2017, 11:26 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20539
> https://issues.apache.org/jira/browse/AMBARI-20539
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Interpreters that are not listed under "zeppelin.interpreter.group.order" in zeppelin-site.xml should not get installed and get configured.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml 039c701
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py 38bfeb4
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py 0a0acdb
> ambari-server/src/test/python/stacks/2.6/configs/default.json a1f89ce
>
>
> Diff: https://reviews.apache.org/r/57872/diff/1/
>
>
> Testing
> -------
>
> Manually on CentOS6
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 57872: Interpreters that are not listed under
"zeppelin.interpreter.group.order" in zeppelin-site.xml should not get
installed
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57872/#review170034
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
Lines 312 (patched)
<https://reviews.apache.org/r/57872/#comment242775>
do,
for settings_key,interpreter in interpreter_settings.itemitems():
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
Lines 314 (patched)
<https://reviews.apache.org/r/57872/#comment242773>
Can remove parentheses and do "not in "
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
Lines 315 (patched)
<https://reviews.apache.org/r/57872/#comment242776>
Not a good idea to delete keys from the dictionary while iterating over it. Create a list of keys to delete
- Alejandro Fernandez
On March 23, 2017, 11:26 a.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57872/
> -----------------------------------------------------------
>
> (Updated March 23, 2017, 11:26 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20539
> https://issues.apache.org/jira/browse/AMBARI-20539
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Interpreters that are not listed under "zeppelin.interpreter.group.order" in zeppelin-site.xml should not get installed and get configured.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml 039c701
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py 38bfeb4
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py 0a0acdb
> ambari-server/src/test/python/stacks/2.6/configs/default.json a1f89ce
>
>
> Diff: https://reviews.apache.org/r/57872/diff/1/
>
>
> Testing
> -------
>
> Manually on CentOS6
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 57872: Interpreters that are not listed under
"zeppelin.interpreter.group.order" in zeppelin-site.xml should not get
installed
Posted by Prabhjyot Singh <pr...@gmail.com>.
> On March 23, 2017, 10:38 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
> > Lines 100 (patched)
> > <https://reviews.apache.org/r/57872/diff/1/?file=1672561#file1672561line100>
> >
> > Is this really meant to be added on an Ambari Upgrade if the customer has this version of Zeppelin?
Thank you for reviewing this. Yes, it is required.
- Prabhjyot
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57872/#review169895
-----------------------------------------------------------
On March 23, 2017, 4:56 p.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57872/
> -----------------------------------------------------------
>
> (Updated March 23, 2017, 4:56 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20539
> https://issues.apache.org/jira/browse/AMBARI-20539
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Interpreters that are not listed under "zeppelin.interpreter.group.order" in zeppelin-site.xml should not get installed and get configured.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml 039c701
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py 38bfeb4
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py 0a0acdb
> ambari-server/src/test/python/stacks/2.6/configs/default.json a1f89ce
>
>
> Diff: https://reviews.apache.org/r/57872/diff/1/
>
>
> Testing
> -------
>
> Manually on CentOS6
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 57872: Interpreters that are not listed under
"zeppelin.interpreter.group.order" in zeppelin-site.xml should not get
installed
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57872/#review169895
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
Lines 100 (patched)
<https://reviews.apache.org/r/57872/#comment242597>
Is this really meant to be added on an Ambari Upgrade if the customer has this version of Zeppelin?
- Alejandro Fernandez
On March 23, 2017, 11:26 a.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57872/
> -----------------------------------------------------------
>
> (Updated March 23, 2017, 11:26 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20539
> https://issues.apache.org/jira/browse/AMBARI-20539
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Interpreters that are not listed under "zeppelin.interpreter.group.order" in zeppelin-site.xml should not get installed and get configured.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml 039c701
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py 38bfeb4
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py 0a0acdb
> ambari-server/src/test/python/stacks/2.6/configs/default.json a1f89ce
>
>
> Diff: https://reviews.apache.org/r/57872/diff/1/
>
>
> Testing
> -------
>
> Manually on CentOS6
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 57872: Interpreters that are not listed under
"zeppelin.interpreter.group.order" in zeppelin-site.xml should not get
installed
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57872/#review169988
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On March 23, 2017, 11:26 a.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57872/
> -----------------------------------------------------------
>
> (Updated March 23, 2017, 11:26 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20539
> https://issues.apache.org/jira/browse/AMBARI-20539
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Interpreters that are not listed under "zeppelin.interpreter.group.order" in zeppelin-site.xml should not get installed and get configured.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml 039c701
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py 38bfeb4
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py 0a0acdb
> ambari-server/src/test/python/stacks/2.6/configs/default.json a1f89ce
>
>
> Diff: https://reviews.apache.org/r/57872/diff/1/
>
>
> Testing
> -------
>
> Manually on CentOS6
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 57872: Interpreters that are not listed under
"zeppelin.interpreter.group.order" in zeppelin-site.xml should not get
installed
Posted by Renjith Kamath <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57872/#review169987
-----------------------------------------------------------
Ship it!
Ship It!
- Renjith Kamath
On March 23, 2017, 11:26 a.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57872/
> -----------------------------------------------------------
>
> (Updated March 23, 2017, 11:26 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20539
> https://issues.apache.org/jira/browse/AMBARI-20539
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Interpreters that are not listed under "zeppelin.interpreter.group.order" in zeppelin-site.xml should not get installed and get configured.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml 039c701
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py 38bfeb4
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py 0a0acdb
> ambari-server/src/test/python/stacks/2.6/configs/default.json a1f89ce
>
>
> Diff: https://reviews.apache.org/r/57872/diff/1/
>
>
> Testing
> -------
>
> Manually on CentOS6
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 57872: Interpreters that are not listed under
"zeppelin.interpreter.group.order" in zeppelin-site.xml should not get
installed
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57872/#review169937
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On March 23, 2017, 11:26 a.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57872/
> -----------------------------------------------------------
>
> (Updated March 23, 2017, 11:26 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20539
> https://issues.apache.org/jira/browse/AMBARI-20539
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Interpreters that are not listed under "zeppelin.interpreter.group.order" in zeppelin-site.xml should not get installed and get configured.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml 039c701
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py 38bfeb4
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py 0a0acdb
> ambari-server/src/test/python/stacks/2.6/configs/default.json a1f89ce
>
>
> Diff: https://reviews.apache.org/r/57872/diff/1/
>
>
> Testing
> -------
>
> Manually on CentOS6
>
>
> Thanks,
>
> Prabhjyot Singh
>
>